Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Firecracker v1.11 #5090

Merged

Conversation

Manciukic
Copy link
Contributor

@Manciukic Manciukic commented Mar 17, 2025

Changes

Reason

Shipping 1.11.0

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@Manciukic Manciukic added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Mar 17, 2025
@Manciukic Manciukic requested a review from JackThomson2 March 17, 2025 16:23
pb8o
pb8o previously approved these changes Mar 17, 2025
xmarcalx
xmarcalx previously approved these changes Mar 17, 2025
Copy link
Contributor

@xmarcalx xmarcalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manciukic Manciukic dismissed stale reviews from xmarcalx and pb8o via 6b6b6b1 March 17, 2025 16:30
JackThomson2
JackThomson2 previously approved these changes Mar 17, 2025
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.19%. Comparing base (c54ecd7) to head (0d54af2).
Report is 11 commits behind head on firecracker-v1.11.

Additional details and impacted files
@@                Coverage Diff                 @@
##           firecracker-v1.11    #5090   +/-   ##
==================================================
  Coverage              83.19%   83.19%           
==================================================
  Files                    247      247           
  Lines                  26641    26641           
==================================================
+ Hits                   22163    22165    +2     
+ Misses                  4478     4476    -2     
Flag Coverage Δ
5.10-c5n.metal 83.67% <ø> (ø)
5.10-m5n.metal 83.66% <ø> (-0.01%) ⬇️
5.10-m6a.metal 82.86% <ø> (-0.01%) ⬇️
5.10-m6g.metal 79.67% <ø> (+<0.01%) ⬆️
5.10-m6i.metal 83.65% <ø> (-0.01%) ⬇️
5.10-m7a.metal-48xl 82.86% <ø> (?)
5.10-m7g.metal 79.67% <ø> (+<0.01%) ⬆️
6.1-c5n.metal 83.66% <ø> (-0.01%) ⬇️
6.1-m5n.metal 83.65% <ø> (-0.01%) ⬇️
6.1-m6a.metal 82.86% <ø> (ø)
6.1-m6g.metal 79.67% <ø> (+<0.01%) ⬆️
6.1-m6i.metal 83.65% <ø> (ø)
6.1-m7a.metal-48xl 82.86% <ø> (?)
6.1-m7g.metal 79.67% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xmarcalx
xmarcalx previously approved these changes Mar 17, 2025
@Manciukic Manciukic dismissed stale reviews from xmarcalx and JackThomson2 via 5d85de3 March 17, 2025 16:51
@Manciukic Manciukic force-pushed the firecracker-v1.11 branch 2 times, most recently from 5d85de3 to a3dbc8c Compare March 17, 2025 17:10
JackThomson2 and others added 8 commits March 18, 2025 09:49
We received a backport adding KVM support for physical timers on ARM.
As a result two new registers are set:

 - CNTHP_CTL_EL2
 - CNTHPS_CVAL_EL2

Updated the fingerprint to include these new registers.

Signed-off-by: Jack Thomson <jackabt@amazon.com>
Enable the physical counter tests to run on amazon linux 2 or 2023 as
the KVM support for these has been backported from 6.4.

Signed-off-by: Jack Thomson <jackabt@amazon.com>
Use a bigger comparison during our assertion of the physical counter
reset. The previous value was a little too low and would sometimes fail.

Signed-off-by: Jack Thomson <jackabt@amazon.com>
to track changes of guest-visible CPU features

Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Adding M7a to our default tested intances and the cross snapshot
pipeline.
Update the README to reflect this change.

Signed-off-by: Jack Thomson <jackabt@amazon.com>
We are investigating volatility in the tcp throughput on m7a for now we
will ignore it, until we find a solution.

Signed-off-by: Jack Thomson <jackabt@amazon.com>
New entry in the changelog for AMD Genoa that is officially onboarded
and tested on Firecracker

Signed-off-by: Jack Thomson <jackabt@amazon.com>
Add m7a to the cpu template pipeline and add msr baselines for the
variant.

Signed-off-by: Jack Thomson <jackabt@amazon.com>
Add 1.11 to the release policy and mark 1.9 as unsupported.

Signed-off-by: Riccardo Mancini <mancio@amazon.com>
We changed the markdown format of CHANGELOG.md to not have escapes for
the square brackets, so the tool broke.
This commit fixes it.

Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Update version number / CHANGELOG / CREDITS

Signed-off-by: Riccardo Mancini <mancio@amazon.com>
@Manciukic
Copy link
Contributor Author

All green, at last! 😎

@Manciukic Manciukic merged commit 4e40479 into firecracker-microvm:firecracker-v1.11 Mar 18, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants