-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fingerprints for new instance types #5086
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5086 +/- ##
=======================================
Coverage 83.18% 83.18%
=======================================
Files 248 248
Lines 26910 26910
=======================================
Hits 22384 22384
Misses 4526 4526
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull request was converted to draft
ebb9268
to
e0420df
Compare
No reason to use an older platform. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
Similar to other buildkite pipeline generation script, we would like to inject an onboarding instance type via --instances arg. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
It's not necessary at the moment, but we will want to test new platform (new Amazon Linux) in the future by injecting via --platforms arg. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
to track change of guest-visible CPU features. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
to track changes of guest-visible CPU features Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
to track changes of guest-visible CPU features. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
It looks like a bit is off:
but it's on older platforms, so not related to this change it seems. |
Changes
Add fingerprints for the following new instance types that we are onboarding
Reason
to track changes of guest-visible CPU features.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
[ ] I have updated any relevant documentation (both in code and in the docs)in the PR.
CHANGELOG.md
.~[ ] If a specific issue led to this PR, this PR closes the issue.[ ] When making API changes, I have followed theRunbook for Firecracker API changes.
integration tests.
[ ] I have linked an issue to every newTODO
.rust-vmm
.