Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fingerprints for new instance types #5086

Merged
merged 6 commits into from
Mar 14, 2025

Conversation

zulinx86
Copy link
Contributor

@zulinx86 zulinx86 commented Mar 14, 2025

Changes

Add fingerprints for the following new instance types that we are onboarding

  • Intel Sapphire Rapids (*7i.metal)
  • AMD Genoa (*7a.metal)
  • Graviton4 (*8g.metal)

Reason

to track changes of guest-visible CPU features.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • [ ] I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • ~~[ ] I have mentioned all user-facing changes in CHANGELOG.md.~
  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • [ ] When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • [ ] I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.18%. Comparing base (983a20a) to head (e1dbd45).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5086   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files         248      248           
  Lines       26910    26910           
=======================================
  Hits        22384    22384           
  Misses       4526     4526           
Flag Coverage Δ
5.10-c5n.metal 83.57% <ø> (ø)
5.10-m5n.metal 83.55% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 82.75% <ø> (+<0.01%) ⬆️
5.10-m6g.metal 79.60% <ø> (ø)
5.10-m6i.metal 83.54% <ø> (ø)
5.10-m7g.metal 79.60% <ø> (ø)
6.1-c5n.metal 83.61% <ø> (+<0.01%) ⬆️
6.1-m5n.metal 83.59% <ø> (-0.01%) ⬇️
6.1-m6a.metal 82.80% <ø> (+<0.01%) ⬆️
6.1-m6g.metal 79.60% <ø> (+<0.01%) ⬆️
6.1-m6i.metal 83.59% <ø> (ø)
6.1-m7g.metal 79.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zulinx86 zulinx86 marked this pull request as draft March 14, 2025 10:34
auto-merge was automatically disabled March 14, 2025 10:34

Pull request was converted to draft

@zulinx86 zulinx86 force-pushed the fingerprint branch 2 times, most recently from ebb9268 to e0420df Compare March 14, 2025 13:53
No reason to use an older platform.

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
Similar to other buildkite pipeline generation script, we would like to
inject an onboarding instance type via --instances arg.

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
It's not necessary at the moment, but we will want to test new platform
(new Amazon Linux) in the future by injecting via --platforms arg.

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
to track change of guest-visible CPU features.

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
to track changes of guest-visible CPU features

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
to track changes of guest-visible CPU features.

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
@zulinx86 zulinx86 marked this pull request as ready for review March 14, 2025 14:07
@zulinx86 zulinx86 added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Mar 14, 2025
@Manciukic
Copy link
Contributor

Manciukic commented Mar 14, 2025

It looks like a bit is off:

{
  "name": "guest_cpu_config",
  "prev": {
    "kvm_capabilities": [],
    "cpuid_modifiers": [
      {
        "leaf": "0xb",
        "subleaf": "0x1",
        "flags": 1,
        "modifiers": [
          {
            "register": "eax",
            "bitmap": "0bxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx1x"
          }
        ]
      }
    ],
    "msr_modifiers": []
  },
  "curr": {
    "kvm_capabilities": [],
    "cpuid_modifiers": [
      {
        "leaf": "0xb",
        "subleaf": "0x1",
        "flags": 1,
        "modifiers": [
          {
            "register": "eax",
            "bitmap": "0bxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx0x"
          }
        ]
      }
    ],
    "msr_modifiers": []
  }
}

but it's on older platforms, so not related to this change it seems.

@zulinx86 zulinx86 merged commit 3476905 into firecracker-microvm:main Mar 14, 2025
7 of 8 checks passed
@zulinx86 zulinx86 deleted the fingerprint branch March 14, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants