doc(vsock): clarify vsock support on snapshot/restore #5064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalyazin
previously approved these changes
Mar 5, 2025
bchalios
previously approved these changes
Mar 5, 2025
The current documentation is not clear, mentioning that the device could break if active at time of snapshot. It also mentions that this is fixed by resetting the device at snapshot time, closing all open connections. This patch clarifies that vsock connections are explicitly closed by a transport reset, in order to avoid the aforementioned issue. This doesn't impact listening sockets as they are able to accept new connections after restore. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
kalyazin
approved these changes
Mar 5, 2025
bchalios
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This patch clarifies that vsock connections are explicitly closed by a transport reset, in order to avoid the aforementioned issue. This doesn't impact listening sockets as they are able to accept new connections after restore.
Reason
The current documentation is not clear, mentioning that the device could break if active at time of snapshot. It also mentions that
this is fixed by resetting the device at snapshot time, closing all open connections.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.