Added mount directory to build_rootfs command #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sondavidb
force-pushed
the
add-mount-directory
branch
from
2536e1f
to
c407b32
Compare
|
Thanks @sondavidb 👍 Can you rebase against main now that #445 has been merged? Buildkite is failing the install step because of this |
sondavidb
force-pushed
the
add-mount-directory
branch
from
3dc1669
to
c407b32
Compare
Signed-off-by: David Son <son.david.b@gmail.com>
sondavidb
force-pushed
the
add-mount-directory
branch
from
c407b32
to
202159d
Compare
|
@ginglis13 All good I think, had some issues rebasing but I think I did it |
kzys
approved these changes
Sep 2, 2022
ginglis13
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Son son.david.b@gmail.com
Issue #, if available:
Description of changes:
Firecracker's
build_rootfscommand now supports specifying a mount directory via the-mflag. This should (hopefully) make the pipeline a little less flaky if this is indeed the reason for the command to seemingly randomly fail.It's worth nothing that if this is the real issue (which it seems to not be), this means we can remove the pipeline concurrency group. I think I shared some info with the team as to what behaviors are shown before the loop device setup fails (specifically, when creating the working directory in the first pipeline step, the ones that fail to setup the loop device seem to have a different setup process than the ones that pass), so maybe a deeper dive into that would help fix pipeline flakiness. Still, this is nice to have.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.