Upgrade Go from 1.13 to 1.15 #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our Debian-based BuildKite host now has Go 1.15 to unblock github.com/go-openapi/runtime upgrade. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
|
The |
kzys
force-pushed
the
go115
branch
7 times, most recently
from
5beb346
to
a3fa2b8
Compare
Firecracker is making some breaking changes before reaching 1.0. Due to that, it is hard to make the SDK work with released versions and main branch. This commit makes Firecracker main branch's test failures "soft fail", meaning, tests are still run against the branch, but the failures wouldn't impact the overall test result. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
|
Another blocker is firecracker-microvm/firecracker#2876. Firecracker 1.0 is coming. So we need to take these changes anyway later. |
aarongoulet
approved these changes
Jan 28, 2022
Kern--
approved these changes
Jan 28, 2022
austinvazquez
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-openapineeds Go 1.15, which we probably should adopt rather than stop updating. Go 1.15 and Go 1.13 are no longer supported according to https://go.dev/doc/devel/release. We need to discuss Define supported Go versions #364 later.