Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rag docs missing lib #901

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix: rag docs missing lib #901

merged 1 commit into from
Sep 16, 2024

Conversation

xavidop
Copy link
Contributor

@xavidop xavidop commented Sep 12, 2024

Yesterday I was running a the docs example and this lib was missing from the tutorial!

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
  • Changelog updated
  • Docs updated

@i14h i14h requested a review from kevinthecheung September 13, 2024 16:06
i2amsam
i2amsam approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@i2amsam i2amsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@i2amsam i2amsam merged commit 34d495c into firebase:main Sep 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i2amsam i2amsam i2amsam approved these changes

@kevinthecheung kevinthecheung Awaiting requested review from kevinthecheung

Assignees
No one assigned
Labels
None yet
Projects
Genkit Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xavidop @i2amsam