Fixing bugs in prompt rendering #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apascal07
reviewed
Aug 27, 2024
|
Please add descriptive comments to all user-facing exported functions and types (e.g. |
|
Added some better docs for public methods. |
apascal07
reviewed
Aug 27, 2024
maxl0rd
force-pushed
the
ml_prompt_output
branch
from
72e54a6 to
929cf16
Compare
apascal07
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug reported in #422 where
renderPromptdoes not preserve the output schema that the prompt function returns.This also fixes the bug reported in #757 where
Dotprompt.render()only accepts default options. With this change, therenderandgeneratemethods will accept any options, unless a model is also passed in the method, in which case it requires the custom options defined by that model.