Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect config.required for auth #698

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Respect config.required for auth #698

merged 1 commit into from
Jul 26, 2024

Conversation

rainshen49
Copy link
Contributor

@rainshen49 rainshen49 commented Jul 26, 2024

I think the original intention of the author was to default to true if config.required isn't specified, but ||true will just always evaluate to true. This blocks me when I was following the onboarding flow of https://firebase.google.com/docs/genkit/get-started#gemini-google-ai

Checklist (if applicable):

  • Tested (manually, unit tested, etc.) -- there were no previous unit tests for this bit.
  • Changelog updated
  • Docs updated

@sam-gc sam-gc merged commit 9f0782f into firebase:main Jul 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants