[Go] replace IsKnownModel with IsDefinedModel #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelgj
approved these changes
Jul 15, 2024
IsDefinedModel is more general. You can call it right after Init to determine if a model is known, or any time to see if you've already defined a model, and avoid the panic from DefineModel. Also remove KnownModels. It's unclear if it's useful. If it is, we can always add it later. Do the same for embedders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsDefinedModel is more general. You can call it right after Init
to determine if a model is known, or any time to see if you've already
defined a model, and avoid the panic from DefineModel.
Also remove KnownModels. It's unclear if it's useful. If it is, we can
always add it later.
Do the same for embedders.