[Go] test picoschema with yaml test cases #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the yaml file of test cases to test the Go picoschema implementation. This uncovered a few problems. Some new features were implemented in JS but not in Go; they are implemented here. More seriously, it was discovered that the JSON schema package we are using, github.com/invopop/jsonschema, does not support arrays for the "type" field, and probably never will (see invopop/jsonschema#134). Tests that require that are skipped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the yaml file of test cases to test the Go picoschema implementation.
This uncovered a few problems. Some new features were implemented in
JS but not in Go; they are implemented here.
More seriously, it was discovered that the JSON schema package we
are using, github.com/invopop/jsonschema, does not support
arrays for the "type" field, and probably never will (see
invopop/jsonschema#134). Tests that
require that are skipped.