Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): fix bug where dev UI configs aren't respected #2234

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

huangjeff5
Copy link
Contributor

@huangjeff5 huangjeff5 commented Mar 4, 2025

Tested manually in Dev UI and code invocation paths.

@huangjeff5 huangjeff5 marked this pull request as ready for review March 4, 2025 18:01
@huangjeff5 huangjeff5 requested a review from apascal07 March 4, 2025 18:02
@huangjeff5 huangjeff5 requested a review from apascal07 March 11, 2025 14:33
@@ -108,6 +108,7 @@ type ModelInfo struct {
Label string `json:"label,omitempty"`
Supports *ModelInfoSupports `json:"supports,omitempty"`
Versions []string `json:"versions,omitempty"`
ConfigSchema map[string]any `json:"configSchema,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to come from genkit-tools otherwise it will get overwritten on next generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants