-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js/plugins): added experimental_debugTraces
option to googleai and vertexai plugins
#2023
Conversation
Questions: Does this need to be plugin-specific? Or is there something we can do at the framework level to enable this for all plugins? |
I think there's an opportunity to do something at the framework level, but tracing logic must be implemented per-plugin anyway... I think it's fine like this. We can revisit this later. For now the dev can always do something like: const ai = genkit({
plugins: [googleAI({debugTraces: process.env.DEBUG_TRACES === 'true'})],
}); |
This is super interesting, thanks! It's potentially relevant to some things we are looking at in AIM. I have a few questions.
Should we consider (in addition to input/output, which is Genkit specific) layering in the semantic conventions? If we write this trace according to the semantic conventions, in production, Cloud Trace will show it really nicely in a gen AI specific view. and eventually AIM will too. Currently, we are planning to do that on the model action span: #1601 See also: https://opentelemetry.io/docs/specs/semconv/gen-ai/gen-ai-spans/ |
Couple more questions. Is this mostly geared towards our team (i.e. people developing Genkit)? Or do we expect app developers to use it? Troubleshooting with us? In prod? I am wondering if "debug" is descriptive enough for what the use case is (all tracing is debug related in a way 😄) versus say "internal" traces. Inspiration: https://opentelemetry.io/docs/collector/internal-telemetry/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks cool. I want to use it already! It also made me think of a bunch of questions.
Beyond that, I believe it will be super helpful for developers who are already familiar with provider SDK to understand what Genkit actually does to generate the request.
|
I think devs might be interested in looking at those traces... those traces should look familiar to devs who used the SDK directly in the past... but internal-telemetry approach looks interesting as well. |
debugTraces
option to googleai and vertexai pluginsexperimental_debugTraces
option to googleai and vertexai plugins
decided to prefix the flag with |
Checklist (if applicable):