fix(js/plugins/google-cloud): pass projectId through to GoogleAuth client #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDoyle
force-pushed
the
fix-project-id
branch
2 times, most recently
from
6047fc0 to
af83a14
Compare
MichaelDoyle
force-pushed
the
fix-project-id
branch
4 times, most recently
from
1687048 to
b993d13
Compare
MichaelDoyle
force-pushed
the
fix-project-id
branch
from
0aaca5a to
3e84881
Compare
schnecle
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the various Google telemetry clients will perform their own credential/project lookups, we need to make sure we're always passing the user provided
projectIdinto their constructors. Otherwise,GCLOUD_PROJECTwill take precedence, and we don't want that. :)Checklist (if applicable):