BREAKING CHANGE!(js): Rip out onFlow and firebaseAuth. Update all docs #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to use functions SDK
github-actions
bot
added
docs
pavelgj
reviewed
Feb 3, 2025
pavelgj
reviewed
Feb 3, 2025
pavelgj
reviewed
Feb 3, 2025
pavelgj
reviewed
Feb 3, 2025
pavelgj
approved these changes
Feb 3, 2025
taeold
reviewed
Feb 3, 2025
MichaelDoyle
reviewed
Feb 3, 2025
Co-authored-by: Daniel Lee <taeold@gmail.com>
Co-authored-by: Michael Doyle <michaeldoyle@google.com>
jhuleatt
reviewed
Feb 3, 2025
…rge' into inlined.firebase-purge
egilmorez
reviewed
Feb 3, 2025
thedmail
reviewed
Feb 4, 2025
| @@ -5,9 +5,13 @@ use https://github.com/firebase/firebase-tools/blob/master/templates/init/functi | |||
|
|
|||
| The Firebase plugin provides integrations with Firebase services, allowing you to build intelligent and scalable AI applications. Key features include: | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
These merge-conflict markers shouldn't be here.
Is the net-net this?
- Firestore Vector Store: Use Firestore for indexing and retrieval with vector embeddings.
- Cloud Functions: Deploy flows as HTTPS-triggered functions.
- Firebase Authentication: Implement authorization policies.
Irillit
pushed a commit
that referenced
this pull request
Feb 5, 2025
#1798) onFlow is being removed in favor of onCallGenkit in firebase-functions/https. This allows users to use genkit consistently across all environments. Web frameworks (e.g. express, next, firebase-functions) use simple handler functions to use a flow that is defined abstract of the transport protocol. firebaseAuth is being temporarily removed because it is tightly coupled with onFlow. It will be added in the future as generic middleware that can be used by @genkit-ai/express and @genkit-ai/next to both allow easy enforcement of auth/appCheck and to provide a contex to the flow that is consistent with the one provided by onCallGenkit. Co-authored-by: Daniel Lee <taeold@gmail.com> Co-authored-by: Michael Doyle <michaeldoyle@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs now explain to use onCallGenkit and have appropriate authPolicy docs.
Also update docs now that flows don't have an authPolicy themselves.
We still need to update
migrating-from-0.5.mdwhich currently explains howto update to 0.9 not 1.0
firebaseAuth(or should it be calledfirebaseContext? Will be added in the futureas a request middleware that can be used by express and next.js, but we will not
block 1.0 on their completion.
Checklist (if applicable):