Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use env var to track telemetryServerUrl #1776

Merged
merged 8 commits into from
Feb 4, 2025
Merged

fix: use env var to track telemetryServerUrl #1776

merged 8 commits into from
Feb 4, 2025

Conversation

ssbushi
Copy link
Contributor

@ssbushi ssbushi commented Feb 1, 2025

  • A bug causes the telemetry server started by 'genkit start' to be overridden by the ephemeral telemetry server of CLI commands like 'genkit flow:run'.
  • This results in the runtime being stuck with the CLI's telemetry server URL, causing subsequent writes to fail.
  • Solution in this PR is to use the GENKIT_TELEMETRY_SERVER env var to track telemetryServerUrl

Checklist (if applicable):

@ssbushi ssbushi requested review from pavelgj and apascal07 February 1, 2025 03:39
@ssbushi ssbushi changed the title fix: env var to track TS fix: use env var to track telemetryServerUrl Feb 3, 2025
@ssbushi ssbushi requested a review from pavelgj February 3, 2025 21:34
@ssbushi ssbushi requested a review from apascal07 February 3, 2025 22:16
@ssbushi ssbushi merged commit a6c7881 into main Feb 4, 2025
7 checks passed
@ssbushi ssbushi deleted the sb/telemetryFix branch February 4, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants