fix: pipe stdin from genkit start process (#1224)

firebase · Nov 9, 2024 · 4071754 · 4071754
1 parent 59e2cab
commit 4071754
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 29 deletions.
diff --git a/genkit-tools/cli/src/commands/start.ts b/genkit-tools/cli/src/commands/start.ts
@@ -39,12 +39,10 @@ export const start = new Command('start')
           env: { ...process.env, GENKIT_ENV: 'dev' },
         });
 
-        appProcess.stdout?.on('data', (data) => {
-          process.stdout.write(data);
-        });
-        appProcess.stderr?.on('data', (data) => {
-          process.stderr.write(data);
-        });
+        appProcess.stderr?.pipe(process.stderr);
+        appProcess.stdout?.pipe(process.stdout);
+        process.stdin?.pipe(appProcess.stdin);
+
         appProcess.on('error', (error): void => {
           console.log(`Error in app process: ${error}`);
           reject(error);

diff --git a/genkit-tools/common/src/plugin/plugins.ts b/genkit-tools/common/src/plugin/plugins.ts
@@ -16,7 +16,6 @@
 
 import { execSync } from 'child_process';
 import * as clc from 'colorette';
-import { createInterface } from 'readline/promises';
 import { z } from 'zod';
 
 const SupportedFlagValuesSchema = z.union([
@@ -67,11 +66,6 @@ export type SpecialAction = keyof z.infer<typeof ToolPluginSubCommandsSchema>;
 
 const SEPARATOR = '===========================';
 
-const readline = createInterface({
-  input: process.stdin,
-  output: process.stdout,
-});
-
 /**
  * Executes the command given, returning the contents of STDOUT.
  *
@@ -91,20 +85,3 @@ export function cliCommand(command: string, options?: string): void {
 
   console.log(`${SEPARATOR}\n`);
 }
-
-/**
- * Utility function to prompt user for sensitive operations.
- */
-export async function promptContinue(
-  message: string,
-  dfault: boolean
-): Promise<boolean> {
-  console.log(message);
-  const opts = dfault ? 'Y/n' : 'y/N';
-  const r = await readline.question(`${clc.bold('Continue')}? (${opts}) `);
-  if (r === '') {
-    return dfault;
-  }
-
-  return r.toLowerCase() === 'y';
-}