[firebase_storage] Implement "listAll" function #232

danysz · 2019-09-28T13:39:50Z

Description

We implemented the "listAll" function for both Android and iOS.

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
No, this is not a breaking change.

rename function to listAll

Added documentation update in CHANGELOG cleanups

googlebot · 2019-09-28T13:39:56Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

danysz · 2019-09-28T13:42:30Z

@googlebot I fixed it.

googlebot · 2019-09-28T13:42:35Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

emildesign · 2019-09-28T13:43:30Z

@googlebot I consent.

googlebot · 2019-09-28T13:43:35Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

danysz · 2019-09-28T15:06:32Z

I really think that some "settings" for the format which can be imported directly in Android Studio and in Xcode should be provided so the "format" will be made automatically without changing the "Default" which is coming inside.

wladosh · 2020-06-04T13:20:37Z

Is this waiting for a web implementation? or is there something else holding this back?

soon will be a year since I made it and they don't have time to review it. I got in contact with @collinjackson about it (he is the now who made the first review) but it looks that the other guy is just careless about what is going on and nobody cares about the developers.
I stopped updating firebase and other open sources since nobody is doing anything about it.
You can point to my repository and use it.

BTW, since I made it because a lot of changes there are now conflicts.

enjoy

that's really sad you did good work and I really need this in my project...

conleec · 2020-06-08T20:40:11Z

Sigh...
That is sad...

kormemis · 2020-06-10T03:18:44Z

.listAll() function returns as Future , how could I convert it as ListResult ?
thanks.

Ehesp · 2020-06-10T07:40:52Z

Hi All - Storage is on the list to be sorted as part of #2582 and this will be addressed.

Thanks for the work that's been put in. As we're working on updating the tests & CI flow for each plugin, I think it'd be best if we hold of merging this one since it bumps the underlying native SDK versions. Without proper tests in place, it may well break functionality of other plugins/features.

danysz · 2020-06-10T10:43:05Z

Hi All - Storage is on the list to be sorted as part of #2582 and this will be addressed.

Thanks for the work that's been put in. As we're working on updating the tests & CI flow for each plugin, I think it'd be best if we hold of merging this one since it bumps the underlying native SDK versions. Without proper tests in place, it may well break functionality of other plugins/features.

Thanks...when I made it first everything was update and everything was possible to be merged automatically, but it was looooong time ago.

abhirakshit · 2020-07-02T17:13:09Z

Any ETA on when this might make to release please?

Harishwarrior · 2020-07-07T10:21:13Z

This is the important feature used by almost every firebase user. Any ETA on the plugin update?. If this will take too long then i will switch to java. That's why am asking.

mirkelor · 2020-07-13T12:11:11Z

Please review this pr.

Harishwarrior · 2020-08-04T15:36:19Z

Hi All - Storage is on the list to be sorted as part of #2582 and this will be addressed.

Thanks for the work that's been put in. As we're working on updating the tests & CI flow for each plugin, I think it'd be best if we hold of merging this one since it bumps the underlying native SDK versions. Without proper tests in place, it may well break functionality of other plugins/features.

Thanks...when I made it first everything was update and everything was possible to be merged automatically, but it was looooong time ago.

Can you update it now?

danysz · 2020-08-06T06:12:43Z

Hi All - Storage is on the list to be sorted as part of #2582 and this will be addressed.
Thanks for the work that's been put in. As we're working on updating the tests & CI flow for each plugin, I think it'd be best if we hold of merging this one since it bumps the underlying native SDK versions. Without proper tests in place, it may well break functionality of other plugins/features.

Thanks...when I made it first everything was update and everything was possible to be merged automatically, but it was looooong time ago.

Can you update it now?

What for ? It doesn't looks that someone really cares about us.

Harishwarrior · 2020-08-06T06:18:59Z

@danysz I don't know why they didn't merge this yet. But, your work is really great. Don't let that fade away. Almost 25 guys I know alone, using this feature.

Edit: and what I meant by update is to resolve the merge conflicts.

danysz · 2020-08-06T06:21:26Z

@danysz I don't know why they didn't merge this yet. But, your work is really great. Don't let that fade away. Almost 25 guys I know alone, using this feature.

I know at least same amount if not double. Some of them even wrote me, but after almost a year waiting and trying actively to get in touch with @collinjackson and others which didn't do anything about it I am just really disappointed.

tgbarker

missing semicolon at end of line 333 plugins/firebase/storage/FirebaseStoragePlugin.java, does not compile.
Thank you for this feature, I still use your branch and noticed it didnt compile this morning.

Ehesp · 2020-08-06T15:29:50Z

This will be added as part of the #2582 rework - it overhauls the API and converts it to a federated setup so we were unable to use this PR. Hopefully the updated work should be landing in a couple of weeks.

Maadhav · 2020-08-20T10:02:11Z

Any update on this? Is this available in the latest version?

gaetschwartz · 2020-08-20T10:07:03Z

@Maadhav Nope it is not available in the latest version... I wonder if they will merge it someday ?

Ehesp · 2020-08-20T10:14:22Z

@blaxou https://github.com/invertase/flutterfire/pull/53

gaetschwartz · 2020-08-20T10:17:02Z

@Ehesp Alright, why do you use two different repositories ? It makes things a lot more confusing for users and issues etc. Also don't hesitate to communicate on in this PR if you work on it, as you probably noticed a lot of people want this feature so let's reassure them !

Ehesp · 2020-08-20T10:19:20Z

@blaxou It allows us to focus on big upgrades without noise from the main one. Once it's up to standard we'll merge them in.

Levi-Lesches · 2020-09-22T05:55:06Z

Not to snoop, but https://github.com/invertase/flutterfire/pull/53 has been merged! Seems to be only a matter of time until it's merged into this repo

Levi-Lesches · 2020-09-22T05:57:29Z

Follow #3612 for progress

Salakar · 2020-09-22T17:26:43Z

Hey all, as @Levi-Lesches mentioned above, our rework PR is up at #3612 and is now going through dev release cycles. A firebase_storage dev release is now available (5.0.0-dev.1) with all the changes in that PR including the listing API - please could you try it out and provide feedback on the #3612 PR :)

Thanks for sending up this PR though @danysz - really appreciate it, sorry it didn't get the attention it deserved. Given that it's now implemented in the other PR I'm going to go ahead and close this PR.

Closes #227 Fixes #225

danysz and others added 9 commits September 25, 2019 23:17

added "list" function

d5b277c

working on new function list

986f85e

now we are getting the results

3ed451a

clean Android code

2f0c6d7

start working on iOS implementation

7c40d32

list function response is parsed from maps.

fa08446

remove logs

57d8426

rename function to listAll

handling the listAll method from the ios side.

97e13a1

Changed version to 3.1.0

8a4cb43

Added documentation update in CHANGELOG cleanups

danysz requested review from collinjackson and kroikie as code owners September 28, 2019 13:39

googlebot added the cla: no label Sep 28, 2019

googlebot added cla: yes and removed cla: no labels Sep 28, 2019

danysz added 6 commits September 28, 2019 16:50

change format from default XCode to default "dart"

648220f

change in indentation

5713bdc

code format

ac46efc

code format

60bfa07

code format

191e2f1

change indentation

57ae754

danysz added 4 commits September 28, 2019 18:16

change indentation

58821e0

again indentation

4cd54fb

more indentation work

64ef3d2

empty rows removal

e1cb841

DanielBerge approved these changes Jun 10, 2020

View reviewed changes

kroikie unassigned collinjackson Jul 2, 2020

add missing filed

434ff6c

tgbarker suggested changes Aug 6, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

Salakar mentioned this pull request Sep 22, 2020

feat(firebase_storage): rework #3612

Merged

22 tasks

Salakar closed this Sep 22, 2020

Ehesp pushed a commit that referenced this pull request Oct 6, 2020

Support FieldValue.increment (#232)

ef7111d

Closes #227 Fixes #225

firebase locked and limited conversation to collaborators Oct 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[firebase_storage] Implement "listAll" function #232

[firebase_storage] Implement "listAll" function #232

danysz commented Sep 28, 2019

googlebot commented Sep 28, 2019

danysz commented Sep 28, 2019

googlebot commented Sep 28, 2019

emildesign commented Sep 28, 2019

googlebot commented Sep 28, 2019

danysz commented Sep 28, 2019 •

edited

Loading

wladosh commented Jun 4, 2020

conleec commented Jun 8, 2020

kormemis commented Jun 10, 2020

Ehesp commented Jun 10, 2020

danysz commented Jun 10, 2020

abhirakshit commented Jul 2, 2020

Harishwarrior commented Jul 7, 2020 •

edited

Loading

mirkelor commented Jul 13, 2020

Harishwarrior commented Aug 4, 2020

danysz commented Aug 6, 2020

Harishwarrior commented Aug 6, 2020 •

edited

Loading

danysz commented Aug 6, 2020

tgbarker left a comment •

edited

Loading

Ehesp commented Aug 6, 2020

This comment has been minimized.

Maadhav commented Aug 20, 2020

gaetschwartz commented Aug 20, 2020

Ehesp commented Aug 20, 2020

gaetschwartz commented Aug 20, 2020

Ehesp commented Aug 20, 2020

Levi-Lesches commented Sep 22, 2020

Levi-Lesches commented Sep 22, 2020

Salakar commented Sep 22, 2020

[firebase_storage] Implement "listAll" function #232

[firebase_storage] Implement "listAll" function #232

Conversation

danysz commented Sep 28, 2019

Description

Related Issues

Checklist

Breaking Change

googlebot commented Sep 28, 2019

danysz commented Sep 28, 2019

googlebot commented Sep 28, 2019

emildesign commented Sep 28, 2019

googlebot commented Sep 28, 2019

danysz commented Sep 28, 2019 • edited Loading

wladosh commented Jun 4, 2020

conleec commented Jun 8, 2020

kormemis commented Jun 10, 2020

Ehesp commented Jun 10, 2020

danysz commented Jun 10, 2020

abhirakshit commented Jul 2, 2020

Harishwarrior commented Jul 7, 2020 • edited Loading

mirkelor commented Jul 13, 2020

Harishwarrior commented Aug 4, 2020

danysz commented Aug 6, 2020

Harishwarrior commented Aug 6, 2020 • edited Loading

danysz commented Aug 6, 2020

tgbarker left a comment • edited Loading

Choose a reason for hiding this comment

Ehesp commented Aug 6, 2020

This comment has been minimized.

Maadhav commented Aug 20, 2020

gaetschwartz commented Aug 20, 2020

Ehesp commented Aug 20, 2020

gaetschwartz commented Aug 20, 2020

Ehesp commented Aug 20, 2020

Levi-Lesches commented Sep 22, 2020

Levi-Lesches commented Sep 22, 2020

Salakar commented Sep 22, 2020

danysz commented Sep 28, 2019 •

edited

Loading

Harishwarrior commented Jul 7, 2020 •

edited

Loading

Harishwarrior commented Aug 6, 2020 •

edited

Loading

tgbarker left a comment •

edited

Loading