feat(vertexai): Unhandled ContentModality fix with more multimodal examples for vertexai testapp #17150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelVerdon
changed the title
russellwheatley
requested changes
Feb 28, 2025
|
I come here from this issue #17133 and this actually works for all types of files. When will it be released? |
MichaelVerdon
changed the title
Hi there, yes it works for all types of files. if the PR is Merged then the release can come as soon as tomorrow. |
Lyokone
reviewed
Mar 3, 2025
packages/firebase_vertexai/firebase_vertexai/example/lib/pages/audio_page.dart
Outdated
Show resolved
Hide resolved
packages/firebase_vertexai/firebase_vertexai/example/lib/pages/audio_page.dart
Outdated
Show resolved
Hide resolved
packages/firebase_vertexai/firebase_vertexai/example/lib/pages/audio_page.dart
Outdated
Show resolved
Hide resolved
packages/firebase_vertexai/firebase_vertexai/example/lib/pages/audio_page.dart
Show resolved
Hide resolved
packages/firebase_vertexai/firebase_vertexai/example/lib/pages/audio_page.dart
Outdated
Show resolved
Hide resolved
packages/firebase_vertexai/firebase_vertexai/example/lib/pages/document.dart
Outdated
Show resolved
Hide resolved
packages/firebase_vertexai/firebase_vertexai/example/lib/pages/video_page.dart
Outdated
Show resolved
Hide resolved
Lyokone
reviewed
Mar 3, 2025
packages/firebase_vertexai/firebase_vertexai/example/lib/pages/audio_page.dart
Outdated
Show resolved
Hide resolved
Lyokone
reviewed
Mar 3, 2025
packages/firebase_vertexai/firebase_vertexai/example/lib/pages/audio_page.dart
Outdated
Show resolved
Hide resolved
Lyokone
reviewed
Mar 3, 2025
packages/firebase_vertexai/firebase_vertexai/example/lib/pages/video_page.dart
Outdated
Show resolved
Hide resolved
Lyokone
approved these changes
Mar 3, 2025
SelaseKay
approved these changes
Mar 3, 2025
cynthiajoan
reviewed
Mar 3, 2025
packages/firebase_vertexai/firebase_vertexai/example/lib/pages/audio_page.dart
Outdated
Show resolved
Hide resolved
cynthiajoan
approved these changes
Mar 3, 2025
|
When this PR will be merged? |
MichaelVerdon
force-pushed
the
vertex-sound-example
branch
from
c304f17 to
410548a
Compare
russellwheatley
approved these changes
Mar 5, 2025
|
I see changes were pushed and got approved as well, now when this open PR will be merged? |
|
i really need this PR to be merged because somehow Codemagic just decided to pick on this PR and stop building my app 😆 |
|
any update on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix 'Unhandle ContentModality' issue for audio.
closes #17133
Add an audio and text, video and text and document and text prompt examples for vertexai testapp to streamline processes of diagnosing audio related issues.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?