Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using default attribute of Firebase require statement if available #398

Merged
merged 2 commits into from
May 15, 2018
Merged

Using default attribute of Firebase require statement if available #398

merged 2 commits into from
May 15, 2018

Conversation

nicolasgarnier
Copy link
Contributor

fixes #392

@nicolasgarnier nicolasgarnier mentioned this pull request May 15, 2018
Closed
@nicolasgarnier
Copy link
Contributor Author

Any idea why the travis build is failing? unrelated?

@bojeil-google
Copy link
Contributor

Seems like flakiness related. trying again.

@bojeil-google bojeil-google merged commit 440c1b3 into master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bojeil-google bojeil-google bojeil-google approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error: firebase.initializeApp is not a function
2 participants
@nicolasgarnier @bojeil-google