-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update password reset handler to handle password policy error #1047
Conversation
0eebc82
to
504b6a6
Compare
d1f5ee6
to
9165252
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NhienLam LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all these translation files give a "bidirectional Unicode" warning in GitHub. Do we need to worry about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this warning in this file only. Per https://github.blog/changelog/2021-10-31-warning-about-bidirectional-unicode-text/, it seems like we can ignore the warning since these bidirectional Unicode texts are added on purpose.
If your use of bidirectional Unicode characters is intentional and not malformed, you can ignore the warning.
9165252
to
b4f90b1
Compare
See notes about the translations: b/308003001#comment2 (internal link)
Testing:
I tested with the demo app and verified that the following work: