Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update password reset handler to handle password policy error #1047

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

NhienLam
Copy link
Contributor

@NhienLam NhienLam commented Oct 31, 2023

See notes about the translations: b/308003001#comment2 (internal link)

Testing:
I tested with the demo app and verified that the following work:

  • Password policy errors (English)
  • Weak password error (English)
  • Sign in/up with password
  • Sign in with Google (redirect + popup)
  • Sign in with phone number
  • Sign in anonymously

Copy link
Collaborator

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Copy link
Collaborator

@jhuleatt jhuleatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NhienLam LGTM! Thank you!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these translation files give a "bidirectional Unicode" warning in GitHub. Do we need to worry about that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this warning in this file only. Per https://github.blog/changelog/2021-10-31-warning-about-bidirectional-unicode-text/, it seems like we can ignore the warning since these bidirectional Unicode texts are added on purpose.

If your use of bidirectional Unicode characters is intentional and not malformed, you can ignore the warning.

@NhienLam NhienLam force-pushed the password-policy-error-handling branch from 9165252 to b4f90b1 Compare November 13, 2023 22:07
@NhienLam NhienLam merged commit 44884c7 into master Nov 13, 2023
2 checks passed
@NhienLam NhienLam deleted the password-policy-error-handling branch November 13, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants