Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uiCallback #22

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Fix uiCallback #22

merged 1 commit into from
Mar 8, 2018

Conversation

jekh
Copy link
Contributor

@jekh jekh commented Mar 8, 2018

The uiCallback prop wasn't being assigned in the class, causing the if check on line 55 to always be false, rendering the uiCallback prop ineffective.

@nicolasgarnier nicolasgarnier merged commit 2c867db into firebase:master Mar 8, 2018
@nicolasgarnier
Copy link
Contributor

Thanks for the fix @jekh !

@nicolasgarnier
Copy link
Contributor

Just released v1.1.9

@jekh jekh deleted the fix-uiCallback branch March 8, 2018 16:48
@jekh
Copy link
Contributor Author

jekh commented Mar 13, 2018

Thanks, @nicolasgarnier! This is fantastic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jekh @nicolasgarnier