Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies: 🔥 Firebase 8 and ⚛️ React 17 #122

Merged
merged 11 commits into from
Apr 26, 2021
Merged

Conversation

jhuleatt
Copy link
Contributor

@jhuleatt jhuleatt commented Dec 4, 2020

@jhuleatt
Copy link
Contributor Author

jhuleatt commented Dec 4, 2020

This has been published to npm with a canary tag. Try it out by running:

npm install react-firebaseui@canary

@brendanmc6
Copy link

brendanmc6 commented Feb 2, 2021

Sorry if this is a stupid question, will this fix this import error? #114

Attempted import error: 'app' is not exported from 'firebase/app' (imported as 'firebase').

Just asking because I couldn't spot any relevant changes in the diff-- I guess the firebaseui version bump is enough?

@HugoGresse
Copy link

I had almost no issue with the canary yet, no import issue (React 17)
The only things was that I needed it to pin the firebaseui version to 4.7.3 to benefit for the auth emulator fixes.

@OrhanTozan
Copy link

@jhuleatt Sorry for asking, but why is this still not merged to master after 4 months? 😀

@david-wb
Copy link

Please merge this soon. Firebase 8 has been out for 5 months.

@tomseago
Copy link

tomseago commented Apr 7, 2021

Not to dog-pile, but yeah, would love to drop the need for @canary on this one...

@chris-rock
Copy link

@samtstern Can you help with this? It would be great if the react plugin moves forward.

@jhuleatt jhuleatt merged commit 11cf289 into master Apr 26, 2021
@jhuleatt
Copy link
Contributor Author

react-firebaseui version 5.0.0 has been published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update firebase peer dependency to support 8.x.x
7 participants