-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mila/MultiDB #738
Merged
Merged
Mila/MultiDB #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-andersen
requested changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is some initial feedback. I will do a more thorough review when you are ready.
milaGGL
added
the
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
label
May 30, 2023
milaGGL
added
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
and removed
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
labels
May 30, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
and removed
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
labels
May 30, 2023
milaGGL
added
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
and removed
tests: in-progress
This PR's integration tests are in progress.
labels
May 30, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
labels
May 31, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
May 31, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
and removed
tests: failed
This PR's integration tests failed.
labels
Jun 1, 2023
github-actions
bot
added
tests: failed
This PR's integration tests failed.
and removed
tests-requested: quick
Trigger a quick set of integration tests.
labels
Jun 15, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Jun 15, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests: failed
This PR's integration tests failed.
labels
Jun 16, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Jun 16, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests: failed
This PR's integration tests failed.
labels
Jun 16, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Jun 16, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests: failed
This PR's integration tests failed.
labels
Jun 16, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Jun 16, 2023
milaGGL
requested review from
tom-andersen and
markarndt
and removed request for
tom-andersen and
markarndt
June 19, 2023 15:50
tom-andersen
approved these changes
Jun 21, 2023
markarndt
approved these changes
Jun 22, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests: failed
This PR's integration tests failed.
labels
Jun 22, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multiDB support.
Ported from cpp SDK: firebase/firebase-cpp-sdk#1321
TODO:
FirestoreInstanceCacheKey
as key instead ofFirebaseApp
to identify databases in the same app while creating/deleting firestore instances.How to test locally:
fire up the local firestore emulator
Uncomments the following line of code in
firestore/testapp/Assets/Firebase/Sample/Firestore/UIHandlerAutomated.cs
to set theUSE_FIRESTORE_EMULATOR
environment variable:Environment.SetEnvironmentVariable("USE_FIRESTORE_EMULATOR", "true");
The port number is default to “8080”. If your Firestore emulator is running on a different port number, add the following line of code to modify
FIRESTORE_EMULATOR_PORT
Environment.SetEnvironmentVariable("FIRESTORE_EMULATOR_PORT", <port_number>);
Run the
UIHandelerAutomated
tests again. This time all tests should run against the local Firestore emulator.To switch back to running tests on the production backend, set the
USE_FIRESTORE_EMULATOR
to null.