Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dot env files in windows #8086

Merged
merged 6 commits into from
Jan 27, 2025
Merged

fix dot env files in windows #8086

merged 6 commits into from
Jan 27, 2025

Conversation

leoortizz
Copy link
Member

Description

Fixes #8076 by telling glob to use Windows path delimiters on Windows.

Scenarios Tested

Tested with an .env.production file on Windows

Sample Commands

firebase deploy

@leoortizz leoortizz self-assigned this Dec 30, 2024
@leoortizz leoortizz mentioned this pull request Dec 30, 2024
Closed
chalosalvador
chalosalvador approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@chalosalvador chalosalvador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoortizz leoortizz enabled auto-merge (squash) January 27, 2025 23:20
@leoortizz leoortizz merged commit 753f032 into master Jan 27, 2025
44 of 46 checks passed
@leoortizz leoortizz deleted the leoortizz_fixWindowsDotEnv branch January 27, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalosalvador chalosalvador chalosalvador approved these changes

@jamesdaniels jamesdaniels Awaiting requested review from jamesdaniels

Assignees

@leoortizz leoortizz

Labels
integration: web frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dotenv files ignored when deploying nextjs apps
2 participants
@leoortizz @chalosalvador