Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always log reauth error messages #7875

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Always log reauth error messages #7875

merged 4 commits into from
Nov 12, 2024

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Oct 25, 2024

Description

Always log reauth errors.

This error gets used in many places accross the CLI, and it is easy to accidentally swallow the user facing error message here. Rather than digging through all of the code base to address this, we'll just log this here.

@joehan joehan requested a review from NickChittle October 25, 2024 21:12
Copy link
Contributor

@NickChittle NickChittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joehan joehan enabled auto-merge (squash) October 25, 2024 22:09
@joehan joehan merged commit 07c7cd8 into master Nov 12, 2024
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants