Added status header for query upload requests #5425
Conversation
Codecov ReportBase: 56.32% // Head: 56.32% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5425 +/- ##
==========================================
- Coverage 56.32% 56.32% -0.01%
==========================================
Files 315 315
Lines 21324 21325 +1
Branches 4349 4349
==========================================
Hits 12011 12011
- Misses 8272 8273 +1
Partials 1041 1041
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
|
||
| expect(uploadStatus).to.equal("final"); | ||
|
|
||
| queryUploadStatus = await supertest(firebaseHost) |
There was a problem hiding this comment.
please create a new test, go/refactoring/test-one-thing-at-a-time
| @@ -390,6 +425,17 @@ describe("Firebase Storage endpoint conformance tests", () => { | |||
| }) | |||
| .expect(200); | |||
|
|
|||
| const queryUploadStatus = await supertest(firebaseHost) | |||
There was a problem hiding this comment.
please create a new test, go/refactoring/test-one-thing-at-a-time
|
|
||
| expect(uploadStatus).to.equal("final"); | ||
|
|
||
| queryUploadStatus = await supertest(firebaseHost) | ||
| .put(uploadURL.pathname + uploadURL.search) | ||
| // No Authorization required in finalize |
| @@ -162,6 +165,17 @@ describe("Firebase Storage endpoint conformance tests", () => { | |||
| .expect(200) | |||
| .then((res) => new URL(res.header["x-goog-upload-url"])); | |||
|
|
|||
| let queryUploadStatus = await supertest(firebaseHost) | |||
| .put(uploadURL.pathname + uploadURL.search) | |||
| // No Authorization required in finalize | |||
| @@ -162,6 +165,17 @@ describe("Firebase Storage endpoint conformance tests", () => { | |||
| .expect(200) | |||
| .then((res) => new URL(res.header["x-goog-upload-url"])); | |||
|
|
|||
| let queryUploadStatus = await supertest(firebaseHost) | |||
There was a problem hiding this comment.
please create a new test, go/refactoring/test-one-thing-at-a-time
| "x-goog-upload-url", | ||
| "x-goog-upload-status", |
There was a problem hiding this comment.
why are we removing this?
There was a problem hiding this comment.
It's a duplicate :-)
Fixes #5412