Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firestore:delete getConfirmationMessage should include current project #3457

Merged
merged 4 commits into from
Jun 8, 2021
Merged

firestore:delete getConfirmationMessage should include current project #3457

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e114bba
firestore:delete getConfirmationMessage note proj.
davidbrenner Jun 7, 2021
af0a7a5
Merge branch 'master' into patch-1
samtstern Jun 8, 2021
1979c19
Update firestore-delete.ts
samtstern Jun 8, 2021
4c8d8c8
Update firestore-delete.ts
samtstern Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/commands/firestore-delete.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,28 +26,41 @@ function getConfirmationMessage(deleteOp: FirestoreDelete, options: any) {
return (
"You are about to delete the document at " +
clc.cyan(deleteOp.path) +
" and all of its subcollections. Are you sure?"
" and all of its subcollections " +
" for " +
clc.cyan(options.project) +
". Are you sure?"
);
}

// Shallow document delete
return "You are about to delete the document at " + clc.cyan(deleteOp.path) + ". Are you sure?";
return (
"You are about to delete the document at " +
clc.cyan(deleteOp.path) +
" for " +
clc.cyan(options.project) +
". Are you sure?"
);
}

// Recursive collection delete
if (options.recursive) {
return (
"You are about to delete all documents in the collection at " +
clc.cyan(deleteOp.path) +
" and all of their subcollections. " +
"Are you sure?"
" and all of their subcollections " +
" for " +
clc.cyan(options.project) +
". Are you sure?"
);
}

// Shallow collection delete
return (
"You are about to delete all documents in the collection at " +
clc.cyan(deleteOp.path) +
" for " +
clc.cyan(options.project) +
". Are you sure?"
);
}
Expand Down