bugfix(function deployment on Node v15.8.0) Bumped to archiver v5 from v3 #3135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3120
Function deployment was failing on latest version of Node (as of writing). Migrating from archiver v3 to v5 seems to solve the issue.
The root cause was related to archiverjs/node-archiver#491 and nodejs/node#37027
Breaking changes in archiver v4 was:
breaking: remove support for versions under 8.
And v5 was:
breaking: absolute path glob patterns are no longer supported: use cwd option instead.
Neither of which effects this repo as far as I can tell.
Scenarios Tested
I tested function deployments on Node v10.13, v12, v14, and v15.8.0
Sample Commands
N/A