Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hosting deploy wrongly assumes all-or-none webframeworks #8168

Closed
fivecar opened this issue Feb 5, 2025 · 2 comments · Fixed by #8169
Closed

Hosting deploy wrongly assumes all-or-none webframeworks #8168

fivecar opened this issue Feb 5, 2025 · 2 comments · Fixed by #8169
Labels
api: hosting integration: web frameworks reproducible type: bug

Comments

@fivecar
Copy link
Contributor

fivecar commented Feb 5, 2025 •
edited
Loading

Environment info

firebase-tools:
13.30.0

Platform:
Ubuntu

Test case

  1. Create a firebase.json with two hosting targets: one using webframeworks and one normal (i.e. "target: framey" with source and "target: classic" with public).
  2. Attempt firebase deploy --only hosting:classic

Steps to reproduce

(same as test case above)

Expected behavior

Deploy of "classic" target to succeed. Of course a deploy of hosting:framey should fail... but I wouldn't expect classic to fail because it doesn't use webframeworks.

Actual behavior

Deployment errors out with "Cannot deploy a web framework from source because the experiment webframeworks is not enabled. To enable webframeworks run firebase experiments:enable webframeworks."

I suspect this line is the problem. The tools shouldn't be asserting webframeworks whenever any target requires it... it should only be asserting it for the specific target if it uses it.
fivecar added a commit to fivecar/firebase-tools that referenced this issue Feb 5, 2025
@fivecar
fix: firebase#8168 - enforce webframeworks only when needed
a9c586b 
In deployments where `--only hosting:boo` is used, enforce webframeworks
enablement only when the target actually uses webframeworks.
@fivecar fivecar mentioned this issue Feb 5, 2025
Merged
@aalej
Copy link
Contributor

aalej commented Feb 6, 2025 •
edited
Loading

Thanks for the detailed report and for submitting a PR @fivecar! I’m able to reproduce the error you mentioned. I do think that this behavior can be improved by only asserting webframeworks to be enabled if the target requires it(uses hosting.source).

Let me ask someone from our engineering team to take a look into this.

@fivecar
Copy link
Contributor Author

fivecar commented Feb 6, 2025

@aalej : I've already attached a PR that fixes it (#8169). So this only needs the eng team to approve the PR.

leoortizz added a commit that referenced this issue Mar 6, 2025
@leoortizz
Revert "fix: #8168 - enforce webframeworks only when needed (#8169)"
b75b5eb 
This reverts commit 4621328.
leoortizz added a commit that referenced this issue Mar 7, 2025
@leoortizz
Fix webframeworks deployments when using site in firebase.json (#…
34674ac 
…8295)

* Revert "fix: #8168 - enforce webframeworks only when needed (#8169)"

This reverts commit 4621328.

* prepare webframeworks only if some is being deployed

fixes #8274

* handle only properly

* restore types improvements

* more tests

* cleanup

* changelog

* enforce return type

* remove unnecessary type cast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: hosting integration: web frameworks reproducible type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #8168 - enforce webframeworks only when needed fivecar/firebase-tools
2 participants
@fivecar @aalej