Skip to content

Commit

Permalink
Rename frameworks experiment to internalframeworks to avoid confusion. (
Browse files Browse the repository at this point in the history
#6439)

* Rename frameworks experiment to internalframeworks to avoid confusion.

* Missed a spot.
  • Loading branch information
taeold authored Oct 10, 2023
1 parent 0866cf9 commit b7c8383
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions src/commands/init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ const choices = [
},
];

if (isEnabled("frameworks")) {
if (isEnabled("internalframeworks")) {
choices.push({
value: "frameworks",
value: "internalframeworks",
name: "Frameworks: Get started with Frameworks projects.",
checked: false,
});
Expand All @@ -85,7 +85,7 @@ const featureNames = choices.map((choice) => choice.value);

const DESCRIPTION = `Interactively configure the current directory as a Firebase project or initialize new features in an already configured Firebase project directory.
This command will create or update 'firebase.json' and '.firebaserc' configuration files in the current directory.
This command will create or update 'firebase.json' and '.firebaserc' configuration files in the current directory.
To initialize a specific Firebase feature, run 'firebase init [feature]'. Valid features are:
${[...featureNames]
Expand Down
2 changes: 1 addition & 1 deletion src/experiments.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export const ALL_EXPERIMENTS = experiments({
"without a notice.",
},

frameworks: {
internalframeworks: {
shortDescription: "Allow CLI option for Frameworks",
default: true,
public: false,
Expand Down
4 changes: 2 additions & 2 deletions src/init/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ const featureFns = new Map<string, (setup: any, config: any, options?: any) => P
["hosting:github", features.hostingGithub],
]);

if (isEnabled("frameworks")) {
featureFns.set("frameworks", features.frameworks);
if (isEnabled("internalframeworks")) {
featureFns.set("internalframeworks", features.frameworks);
}

export async function init(setup: Setup, config: any, options: any): Promise<any> {
Expand Down

0 comments on commit b7c8383

Please sign in to comment.