Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vertex GA] Add new endpoint and error message. #8497

Merged
merged 4 commits into from
Sep 24, 2024
Merged

[Vertex GA] Add new endpoint and error message. #8497

merged 4 commits into from
Sep 24, 2024

Conversation

hsubox76
Copy link
Contributor

See b/365756200 (internal).

Endpoint will change for GA. Add a special error message for if the api is not enabled (for users that were using the old endpoint) that guides users to enable it.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0c540bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/vertexai

    TypeBase (09ba48f)Merge (8f8e288)Diff
    browser28.0 kB28.9 kB+907 B (+3.2%)
    main28.8 kB29.7 kB+907 B (+3.1%)
    module28.0 kB28.9 kB+907 B (+3.2%)

  • firebase

    TypeBase (09ba48f)Merge (8f8e288)Diff
    firebase-vertexai.js21.6 kB22.4 kB+806 B (+3.7%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5wYCwix9lN.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 13, 2024 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/vertexai

    • ChatSession

      Size

      TypeBase (09ba48f)Merge (8f8e288)Diff
      size14.1 kB14.9 kB+809 B (+5.7%)
      size-with-ext-deps32.5 kB33.3 kB+810 B (+2.5%)

    • GenerativeModel

      Size

      TypeBase (09ba48f)Merge (8f8e288)Diff
      size16.6 kB17.4 kB+809 B (+4.9%)
      size-with-ext-deps35.0 kB35.9 kB+810 B (+2.3%)

    • getGenerativeModel

      Size

      TypeBase (09ba48f)Merge (8f8e288)Diff
      size16.7 kB17.5 kB+809 B (+4.8%)
      size-with-ext-deps35.2 kB36.0 kB+810 B (+2.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5DmmsoGaVT.html

@hsubox76 hsubox76 changed the title Add new endpoint and error message. [Vertex GA] Add new endpoint and error message. Sep 23, 2024
@hsubox76 hsubox76 marked this pull request as ready for review September 23, 2024 18:08
@hsubox76 hsubox76 requested a review from a team as a code owner September 23, 2024 18:08
@hsubox76 hsubox76 added this to the Vertex GA milestone Sep 23, 2024
@hsubox76 hsubox76 merged commit 245e65e into v11 Sep 24, 2024
39 of 40 checks passed
@hsubox76 hsubox76 deleted the ch-vertex-endpoint branch September 24, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@dlarocque dlarocque dlarocque approved these changes

Assignees
No one assigned
Labels
api: vertexai
Projects
None yet
Milestone
Vertex GA
Development

Successfully merging this pull request may close these issues.
4 participants
@hsubox76 @google-oss-bot @DellaBitta @dlarocque