Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Add a responseMimeType to generationConfig #8235

Merged
merged 4 commits into from
May 8, 2024

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented May 8, 2024

Discussion

Provide Apps with an ability to configure the responseMimeType. This enables applications to request that VertexAI returns the response in a JSON format instead of a normal textual format.

Testing

Local app testing.

Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: 70a2f7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DellaBitta DellaBitta requested a review from hsubox76 May 8, 2024 18:18
@DellaBitta DellaBitta marked this pull request as ready for review May 8, 2024 18:18
@DellaBitta DellaBitta requested a review from a team as a code owner May 8, 2024 18:18
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 8, 2024

Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment to add documentation, otherwise looks good!

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 8, 2024

@DellaBitta DellaBitta requested a review from hsubox76 May 8, 2024 19:28
@DellaBitta DellaBitta merged commit f6a2b88 into ch-vertex-feature May 8, 2024
41 checks passed
@DellaBitta DellaBitta deleted the ddb-vertex-responseMimeType branch May 8, 2024 20:33
@firebase firebase locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants