Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update webchannel-wrapper to fix webchannel multi-byte character decoding bug. #8212

Merged
merged 4 commits into from
May 2, 2024

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented May 1, 2024

No description provided.

Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: 5f1931d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/webchannel-wrapper Patch
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 1, 2024

Size Report 1

Affected Products

  • @firebase/webchannel-wrapper/webchannel-blob

    TypeBase (4b49630)Merge (7ece81c)Diff
    browser44.3 kB42.2 kB-2.15 kB (-4.9%)
    esm555.6 kB53.4 kB-2.21 kB (-4.0%)
    main44.3 kB42.2 kB-2.15 kB (-4.9%)
    module44.3 kB42.2 kB-2.15 kB (-4.9%)
  • bundle

    TypeBase (4b49630)Merge (7ece81c)Diff
    firestore (CSI Auto Indexing Disable and Delete)270 kB268 kB-2.17 kB (-0.8%)
    firestore (CSI Auto Indexing Enable)270 kB268 kB-2.17 kB (-0.8%)
    firestore (Persistence)305 kB303 kB-2.17 kB (-0.7%)
    firestore (Query Cursors)242 kB240 kB-2.17 kB (-0.9%)
    firestore (Query)240 kB238 kB-2.17 kB (-0.9%)
    firestore (Read data once)228 kB226 kB-2.17 kB (-1.0%)
    firestore (Read Write w Persistence)324 kB322 kB-2.17 kB (-0.7%)
    firestore (Realtime updates)230 kB228 kB-2.17 kB (-0.9%)
    firestore (Transaction)207 kB205 kB-2.17 kB (-1.0%)
    firestore (Write data)207 kB205 kB-2.17 kB (-1.0%)
  • firebase

    TypeBase (4b49630)Merge (7ece81c)Diff
    firebase-compat.js787 kB785 kB-2.03 kB (-0.3%)
    firebase-firestore-compat.js343 kB341 kB-2.03 kB (-0.6%)
    firebase-firestore.js438 kB436 kB-2.09 kB (-0.5%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yFYDTdC1a8.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 1, 2024

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • AbstractUserDataWriter

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps97.8 kB95.8 kB-1.98 kB (-2.0%)
    • AggregateField

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.7 kB87.7 kB-1.98 kB (-2.2%)
    • AggregateQuerySnapshot

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.8 kB87.8 kB-1.98 kB (-2.2%)
    • Bytes

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps91.1 kB89.1 kB-1.98 kB (-2.2%)
    • CACHE_SIZE_UNLIMITED

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.6 kB87.6 kB-1.98 kB (-2.2%)
    • CollectionReference

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps93.3 kB91.3 kB-1.98 kB (-2.1%)
    • DocumentReference

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps93.3 kB91.3 kB-1.98 kB (-2.1%)
    • DocumentSnapshot

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps96.8 kB94.8 kB-1.98 kB (-2.0%)
    • FieldPath

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps92.3 kB90.3 kB-1.98 kB (-2.1%)
    • FieldValue

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.6 kB87.6 kB-1.98 kB (-2.2%)
    • Firestore

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.6 kB87.6 kB-1.98 kB (-2.2%)
    • FirestoreError

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.6 kB87.6 kB-1.98 kB (-2.2%)
    • GeoPoint

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.2 kB88.2 kB-1.98 kB (-2.2%)
    • LoadBundleTask

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.4 kB88.5 kB-1.98 kB (-2.2%)
    • PersistentCacheIndexManager

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.7 kB87.7 kB-1.98 kB (-2.2%)
    • Query

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.7 kB87.7 kB-1.98 kB (-2.2%)
    • QueryCompositeFilterConstraint

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps91.8 kB89.9 kB-1.98 kB (-2.2%)
    • QueryConstraint

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.6 kB87.6 kB-1.98 kB (-2.2%)
    • QueryDocumentSnapshot

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps96.8 kB94.8 kB-1.98 kB (-2.0%)
    • QueryEndAtConstraint

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps115 kB113 kB-1.98 kB (-1.7%)
    • QueryFieldFilterConstraint

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps113 kB111 kB-1.98 kB (-1.7%)
    • QueryLimitConstraint

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.4 kB88.4 kB-1.98 kB (-2.2%)
    • QueryOrderByConstraint

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.8 kB88.8 kB-1.98 kB (-2.2%)
    • QuerySnapshot

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps98.7 kB96.7 kB-1.98 kB (-2.0%)
    • QueryStartAtConstraint

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps115 kB113 kB-1.98 kB (-1.7%)
    • SnapshotMetadata

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.7 kB87.8 kB-1.98 kB (-2.2%)
    • Timestamp

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.8 kB88.8 kB-1.98 kB (-2.2%)
    • Transaction

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps124 kB122 kB-1.98 kB (-1.6%)
    • WriteBatch

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps120 kB118 kB-1.98 kB (-1.6%)
    • _AutoId

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.6 kB87.6 kB-1.98 kB (-2.2%)
    • _ByteString

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.6 kB88.7 kB-1.98 kB (-2.2%)
    • _DatabaseId

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.6 kB87.6 kB-1.98 kB (-2.2%)
    • _DocumentKey

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps99.0 kB97.0 kB-1.98 kB (-2.0%)
    • _EmptyAppCheckTokenProvider

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.7 kB87.7 kB-1.98 kB (-2.2%)
    • _EmptyAuthCredentialsProvider

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.6 kB87.6 kB-1.98 kB (-2.2%)
    • _FieldPath

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps92.0 kB90.0 kB-1.98 kB (-2.2%)
    • _TestingHooks

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.1 kB88.1 kB-1.98 kB (-2.2%)
    • _cast

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.4 kB88.4 kB-1.98 kB (-2.2%)
    • _debugAssert

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.6 kB87.6 kB-1.98 kB (-2.2%)
    • _isBase64Available

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.6 kB87.6 kB-1.98 kB (-2.2%)
    • _logWarn

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.7 kB87.7 kB-1.98 kB (-2.2%)
    • _validateIsNotUsedTogether

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.6 kB87.6 kB-1.98 kB (-2.2%)
    • addDoc

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps198 kB195 kB-2.17 kB (-1.1%)
    • aggregateFieldEqual

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.9 kB88.0 kB-1.98 kB (-2.2%)
    • aggregateQuerySnapshotEqual

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps113 kB111 kB-1.98 kB (-1.8%)
    • and

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps115 kB113 kB-1.98 kB (-1.7%)
    • arrayRemove

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps103 kB101 kB-1.98 kB (-1.9%)
    • arrayUnion

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps103 kB101 kB-1.98 kB (-1.9%)
    • average

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps93.3 kB91.4 kB-1.98 kB (-2.1%)
    • clearIndexedDbPersistence

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps98.6 kB96.6 kB-1.98 kB (-2.0%)
    • collection

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps94.1 kB92.1 kB-1.98 kB (-2.1%)
    • collectionGroup

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps93.0 kB91.0 kB-1.98 kB (-2.1%)
    • connectFirestoreEmulator

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps92.0 kB90.0 kB-1.98 kB (-2.2%)
    • count

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.7 kB87.7 kB-1.98 kB (-2.2%)
    • deleteAllPersistentCacheIndexes

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps161 kB159 kB-1.98 kB (-1.2%)
    • deleteDoc

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps188 kB186 kB-2.17 kB (-1.2%)
    • deleteField

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.0 kB88.0 kB-1.98 kB (-2.2%)
    • disableNetwork

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps177 kB175 kB-2.17 kB (-1.2%)
    • disablePersistentCacheIndexAutoCreation

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps161 kB159 kB-1.98 kB (-1.2%)
    • doc

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps94.1 kB92.1 kB-1.98 kB (-2.1%)
    • documentId

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps92.3 kB90.3 kB-1.98 kB (-2.1%)
    • enableIndexedDbPersistence

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps260 kB258 kB-2.17 kB (-0.8%)
    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps296 kB294 kB-2.17 kB (-0.7%)
    • enableNetwork

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps177 kB175 kB-2.17 kB (-1.2%)
    • enablePersistentCacheIndexAutoCreation

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps161 kB159 kB-1.98 kB (-1.2%)
    • endAt

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps116 kB114 kB-1.98 kB (-1.7%)
    • endBefore

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps116 kB114 kB-1.98 kB (-1.7%)
    • ensureFirestoreConfigured

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.7 kB87.7 kB-1.98 kB (-2.2%)
    • executeWrite

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps188 kB185 kB-2.17 kB (-1.2%)
    • getAggregateFromServer

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps184 kB182 kB-2.17 kB (-1.2%)
    • getCountFromServer

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps184 kB182 kB-2.17 kB (-1.2%)
    • getDoc

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps218 kB216 kB-2.17 kB (-1.0%)
    • getDocFromCache

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps168 kB166 kB-1.98 kB (-1.2%)
    • getDocFromServer

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps218 kB216 kB-2.17 kB (-1.0%)
    • getDocs

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps220 kB218 kB-2.17 kB (-1.0%)
    • getDocsFromCache

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps176 kB174 kB-1.98 kB (-1.1%)
    • getDocsFromServer

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps220 kB218 kB-2.17 kB (-1.0%)
    • getFirestore

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps99.9 kB97.9 kB-1.98 kB (-2.0%)
    • getPersistentCacheIndexManager

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.8 kB88.8 kB-1.98 kB (-2.2%)
    • increment

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.5 kB88.5 kB-1.98 kB (-2.2%)
    • initializeFirestore

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps91.0 kB89.0 kB-1.98 kB (-2.2%)
    • limit

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.5 kB88.6 kB-1.98 kB (-2.2%)
    • limitToLast

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps90.6 kB88.6 kB-1.98 kB (-2.2%)
    • loadBundle

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps186 kB184 kB-2.17 kB (-1.2%)
    • memoryEagerGarbageCollector

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps159 kB157 kB-1.98 kB (-1.2%)
    • memoryLocalCache

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps174 kB172 kB-2.17 kB (-1.2%)
    • memoryLruGarbageCollector

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps165 kB163 kB-1.98 kB (-1.2%)
    • namedQuery

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps162 kB160 kB-1.98 kB (-1.2%)
    • onSnapshot

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps221 kB219 kB-2.17 kB (-1.0%)
    • onSnapshotsInSync

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps210 kB208 kB-2.17 kB (-1.0%)
    • or

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps115 kB113 kB-1.98 kB (-1.7%)
    • orderBy

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps94.3 kB92.3 kB-1.98 kB (-2.1%)
    • persistentLocalCache

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps257 kB255 kB-2.17 kB (-0.8%)
    • persistentMultipleTabManager

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps293 kB291 kB-2.17 kB (-0.7%)
    • persistentSingleTabManager

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps257 kB255 kB-2.17 kB (-0.8%)
    • query

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps115 kB113 kB-1.98 kB (-1.7%)
    • queryEqual

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps113 kB111 kB-1.98 kB (-1.8%)
    • refEqual

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps93.5 kB91.5 kB-1.98 kB (-2.1%)
    • runTransaction

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps197 kB195 kB-2.17 kB (-1.1%)
    • serverTimestamp

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.9 kB87.9 kB-1.98 kB (-2.2%)
    • setDoc

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps197 kB195 kB-2.17 kB (-1.1%)
    • setIndexConfiguration

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps164 kB162 kB-1.98 kB (-1.2%)
    • setLogLevel

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.6 kB87.6 kB-1.98 kB (-2.2%)
    • snapshotEqual

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps118 kB116 kB-1.98 kB (-1.7%)
    • startAfter

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps116 kB114 kB-1.98 kB (-1.7%)
    • startAt

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps116 kB114 kB-1.98 kB (-1.7%)
    • sum

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps93.3 kB91.3 kB-1.98 kB (-2.1%)
    • terminate

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps89.9 kB87.9 kB-1.98 kB (-2.2%)
    • updateDoc

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps197 kB195 kB-2.17 kB (-1.1%)
    • waitForPendingWrites

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps177 kB175 kB-2.17 kB (-1.2%)
    • where

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps114 kB112 kB-1.98 kB (-1.7%)
    • writeBatch

      Size

      TypeBase (4b49630)Merge (7ece81c)Diff
      size-with-ext-deps199 kB197 kB-2.17 kB (-1.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Gn5fV680nt.html

@ehsannas ehsannas marked this pull request as ready for review May 1, 2024 22:27
@ehsannas ehsannas requested review from a team as code owners May 1, 2024 22:27
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.changeset/serious-rivers-attend.md Outdated Show resolved Hide resolved
@ehsannas ehsannas merged commit 14f9da6 into master May 2, 2024
44 checks passed
@ehsannas ehsannas deleted the ehsann/update-webchannel-blob-version branch May 2, 2024 18:58
@google-oss-bot google-oss-bot mentioned this pull request May 8, 2024
@firebase firebase locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants