Emit a module package file into esm2017 auth webextension bundle #8191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlarocque
requested review from
lisajian,
Xiaoshouzi-gh,
renkelvin,
sam-gc and
a team
as code owners
🦋 Changeset detectedLatest commit: 084a781 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected ProductsNo changes between base commit (62a20ff) and merge commit (4988fc7).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (62a20ff) and merge commit (4988fc7).Test Logs |
The Firebase Auth webextension bundle was previously being shipped as a CommonJS package rather than a ES module, because it did not have a module package file indicating that it was an ES module. Fixes #8115
dlarocque
force-pushed
the
dlarocque/auth-webextension-emit-module-package
branch
from
3958b10
to
084a781
Compare
hsubox76
approved these changes
Apr 23, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Firebase Auth webextension bundle was previously being shipped as a CommonJS package rather than a ES module, because it did not have a module package file indicating that it was an ES module.
Fixes #8115
Aside: The web-extension entry point does not have a Node bundle, and browser bundles don't normally require a
package.jsonfile with{ "type": "module" }, but certain browser testing frameworks use Node, and need working ES module resolution.