Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert text change from PR 6526 #7696

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Oct 12, 2023

Revert text method description change from PR #6526 and add clarification to text.

@tom-andersen tom-andersen requested review from a team as code owners October 12, 2023 14:26
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023

🦋 Changeset detected

Latest commit: 8b0a1a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 12, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 12, 2023

@tom-andersen tom-andersen requested a review from a team as a code owner October 13, 2023 14:26
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-andersen tom-andersen merged commit 12f2559 into master Oct 16, 2023
41 checks passed
@tom-andersen tom-andersen deleted the tomandersen/revertTextChangeFrom6526 branch October 16, 2023 18:46
@google-oss-bot google-oss-bot mentioned this pull request Oct 25, 2023
prameshj pushed a commit that referenced this pull request Nov 13, 2023
* Revert text change from PR 6526

* Clarify text

* Clarify documentation

* Changeset
@firebase firebase locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants