[CI] update chrome install steps for Auth builds. #7602
Conversation
|
Size Report 1Affected ProductsTest Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (1fd9d25) and merge commit (436d074).Test Logs |
DellaBitta
requested review from
a team,
erikeldridge,
jposuna,
lisajian,
prameshj,
renkelvin,
sam-gc,
zwu52,
maneesht,
tonyjhuang,
jsdt and
jmwski
as code owners
| @@ -124,7 +124,7 @@ | |||
| "@rollup/plugin-json": "4.1.0", | |||
| "@rollup/plugin-strip": "2.1.0", | |||
| "@types/express": "4.17.17", | |||
| "chromedriver": "98.0.1", | |||
| "chromedriver": "114.0.2", | |||
There was a problem hiding this comment.
This pins the version to 114.0.2 for manual installs/test runs on our development machines?
There was a problem hiding this comment.
Yes, this is the chromedriver node module dependency which downloads a varying version of the chromedriver binary (depending oh the currently installed version of chrome.)
The node dependency needed to be updated in order to support the new URLs where Chrome is now hosted.
| sudo apt-get install wget | ||
| sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb | ||
| sudo apt-get install -f ./google-chrome-stable_114.0.5735.90-1_amd64.deb --allow-downgrades | ||
| npx @puppeteer/browsers install chrome@stable |
There was a problem hiding this comment.
Can you also amend the description to specify that the --npm-path option is only needed when npx is involved? The problem (I think) is that npm-run-all mistakenly uses npx instead of npm if the process was started with npx. This was fixed in the fork npm-run-all2 which we may want to look into switching to at some point: bcomnes/npm-run-all2#96
Discussion
Update the Chrome installation steps to use the new method of installation. This unlocks us to test against the latest and greatest chrome versions.
Changes include:
--npm-path npmto allrun-sandrun-pinvocations, as they otherwise fail when invoked vianpxon node v16.Test Auth on Firefox If Changedintest-changed-auth.ymlas it seemed like it seemed superfluous.Testing
CI
API Changes
N/A