Use userAgent instead of depricated appVersion to check for safari indexDB bug.

[KoryNunn]

Currently firestore persistance is broken in cordova, as WKWebView's appVersion does not match Version/1[45], and appVersion is a depricated feature. This PR swaps to checking the userAgent, which is something cordova apps can affect, allowing some level of mitigation of this issue.

Fixes #6509

[changeset-bot]

🦋 Changeset detected

Latest commit: 85a82ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Patch
firebase	Patch
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[KoryNunn]

@dconeybe I have done the CLA, is there a way to re-run these jobs?

[dconeybe]

@dconeybe I have done the CLA, is there a way to re-run these jobs?

I'm not sure. Tagging @cherylEnkidu and @wu-hui, who were working with you on the related bug #6739

[dconeybe]

Hi @KoryNunn. I think you may have linked to the wrong issue number in the description of this PR. You linked to #6739, which is why I tagged my team mates, but that issue doesn't appear to be related to appVersion or user agent at all. I think you meant to link to #6509. Is my thinking correct?

[dconeybe]

Please merge in HEAD of the master branch and push it up. The GitHub actions have likely changed quite a bit.

[KoryNunn]

I did mean #6509 sorry.

I'll merge head shortly

[dconeybe]

Thanks for updating your PR. Since this dark corner of the Firebase code base is unfamiliar with me, I've reached out to some colleagues for advice.

What do you think about leaving the original "if" condition in place, but adding an "or" clause? Basically, check appVersion and userAgent and applying the workaround if at least one of the conditions is true? That would more likely preserve backwards compatibility IMO.

[dconeybe]

Please add a changeset using yarn changeset. It should be a patch release of @firebase/firestore and firebase.

For the changeset description, use something like this:

Check navigator.userAgent, in addition to navigator.appVersion, when determining whether to work around an IndexedDb bug in Safari. Notably, this may be helpful for Cordova apps that lack appVersion in their webview yet need to apply the workaround.

[KoryNunn]

I've updated this PR to more robustly work in both Safari and in WKWebView (the web view used in native apps).

In Safari, the match is Version/{number}, in WKWebView, the match is Mobile/{number}.

Also, this bug is present in version 16, so I added that to the check.

[dconeybe]

LGTM! Will give approval once GitHub Actions pass. Thanks for your time (and a great deal of patience) in making this contribution to the SDK!

[dconeybe]

Please merge at your convenience.

[KoryNunn]

"Only those with write access to this repository can merge pull requests."