-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement configureFieldIndexes with tests #6403
Changes from 5 commits
4949b6c
358db94
13fdd0e
d9da955
ca23225
3c13c49
7fc214d
4c20e49
3e2f542
6bb5633
765def8
f7030a4
ad53de3
484cac1
fb35991
7475c5d
82f0e60
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -473,24 +473,25 @@ export class FirebaseAppCheckTokenProvider | |
asyncQueue: AsyncQueue, | ||
changeListener: CredentialChangeListener<string> | ||
): void { | ||
const onTokenChanged: (tokenResult: AppCheckTokenResult) => Promise<void> = | ||
tokenResult => { | ||
if (tokenResult.error != null) { | ||
logDebug( | ||
'FirebaseAppCheckTokenProvider', | ||
`Error getting App Check token; using placeholder token instead. Error: ${tokenResult.error.message}` | ||
); | ||
} | ||
const tokenUpdated = tokenResult.token !== this.latestAppCheckToken; | ||
this.latestAppCheckToken = tokenResult.token; | ||
const onTokenChanged: ( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this a merge error? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The is the linter making things pretty. It's a minor nuisance to omit committing this file every time I work on JS. So I let it slide this time, and thought it could be included. This is purely a whitespace change. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This does not look like a whitespace change to me..the error message changed for example. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Take a closer look. Githubs diff layout is misleading you. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, see it now! |
||
tokenResult: AppCheckTokenResult | ||
) => Promise<void> = tokenResult => { | ||
if (tokenResult.error != null) { | ||
logDebug( | ||
'FirebaseAppCheckTokenProvider', | ||
`Received ${tokenUpdated ? 'new' : 'existing'} token.` | ||
`Error getting App Check token; using placeholder token instead. Error: ${tokenResult.error.message}` | ||
); | ||
return tokenUpdated | ||
? changeListener(tokenResult.token) | ||
: Promise.resolve(); | ||
}; | ||
} | ||
const tokenUpdated = tokenResult.token !== this.latestAppCheckToken; | ||
this.latestAppCheckToken = tokenResult.token; | ||
logDebug( | ||
'FirebaseAppCheckTokenProvider', | ||
`Received ${tokenUpdated ? 'new' : 'existing'} token.` | ||
); | ||
return tokenUpdated | ||
? changeListener(tokenResult.token) | ||
: Promise.resolve(); | ||
}; | ||
|
||
this.tokenListener = (tokenResult: AppCheckTokenResult) => { | ||
asyncQueue.enqueueRetryable(() => onTokenChanged(tokenResult)); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is just whitespace formatting that happens when the lint:fix and yarn prettier are run.