Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support encoding and decoding Composite Filters #6402

Merged

Conversation

MarkDuckworth
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented Jun 29, 2022

⚠️ No Changeset found

Latest commit: fef4ed0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 29, 2022

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (a722abc)Merge (2169123)Diff
    browser263 kB264 kB+806 B (+0.3%)
    esm5327 kB328 kB+743 B (+0.2%)
    main523 kB525 kB+1.78 kB (+0.3%)
    module263 kB264 kB+806 B (+0.3%)
    react-native264 kB264 kB+806 B (+0.3%)
  • @firebase/firestore-lite

    TypeBase (a722abc)Merge (2169123)Diff
    browser80.9 kB82.0 kB+1.07 kB (+1.3%)
    esm596.7 kB98.0 kB+1.29 kB (+1.3%)
    main136 kB138 kB+2.06 kB (+1.5%)
    module80.9 kB82.0 kB+1.07 kB (+1.3%)
    react-native81.1 kB82.1 kB+1.07 kB (+1.3%)
  • bundle

    11 size changes

    TypeBase (a722abc)Merge (2169123)Diff
    firestore (Persistence)275 kB275 kB+809 B (+0.3%)
    firestore (Query Cursors)211 kB212 kB+809 B (+0.4%)
    firestore (Query)212 kB213 kB+809 B (+0.4%)
    firestore (Read data once)201 kB202 kB+809 B (+0.4%)
    firestore (Realtime updates)203 kB204 kB+809 B (+0.4%)
    firestore (Transaction)185 kB185 kB+586 B (+0.3%)
    firestore (Write data)184 kB185 kB+586 B (+0.3%)
    firestore-lite (Query Cursors)67.9 kB72.9 kB+4.95 kB (+7.3%)
    firestore-lite (Query)71.5 kB72.3 kB+810 B (+1.1%)
    firestore-lite (Transaction)80.0 kB80.0 kB+6 B (+0.0%)
    firestore-lite (Write data)65.2 kB65.2 kB+6 B (+0.0%)

  • firebase

    TypeBase (a722abc)Merge (2169123)Diff
    firebase-compat.js795 kB796 kB+769 B (+0.1%)
    firebase-firestore-compat.js315 kB316 kB+769 B (+0.2%)
    firebase-firestore-lite.js268 kB270 kB+1.74 kB (+0.7%)
    firebase-firestore.js847 kB849 kB+2.17 kB (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rmS75hT7GN.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 29, 2022

Size Analysis Report 1

This report is too large (544,967 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rsTS5V3JWY.html

@MarkDuckworth MarkDuckworth marked this pull request as ready for review July 6, 2022 15:54
@MarkDuckworth MarkDuckworth changed the base branch from master to markduckworth/or-queries July 26, 2022 15:45
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few nits pointed out below.

packages/firestore/src/remote/serializer.ts Show resolved Hide resolved
packages/firestore/src/remote/serializer.ts Outdated Show resolved Hide resolved
packages/firestore/src/remote/serializer.ts Show resolved Hide resolved
packages/firestore/src/remote/serializer.ts Outdated Show resolved Hide resolved
packages/firestore/test/unit/core/query.test.ts Outdated Show resolved Hide resolved
@ehsannas ehsannas assigned MarkDuckworth and unassigned ehsannas Aug 4, 2022
@MarkDuckworth MarkDuckworth merged commit 1e33050 into markduckworth/or-queries Aug 5, 2022
@MarkDuckworth MarkDuckworth deleted the markduckworth/or-queries-pr-3 branch August 5, 2022 19:08
@firebase firebase locked and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants