Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use transaction.commit() if available #5982

Merged
merged 6 commits into from
Feb 9, 2022
Merged

Use transaction.commit() if available #5982

merged 6 commits into from
Feb 9, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Feb 8, 2022 •
edited
Loading

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 42ea106

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Patch
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@schmidt-sebastian schmidt-sebastian changed the title Use transaction.commit() if avaiable Use transaction.commit() if available Feb 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 8, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (bf93a38)Merge (6b2730d)Diff
    browser231 kB231 kB+106 B (+0.0%)
    esm5288 kB289 kB+141 B (+0.0%)
    main460 kB460 kB+202 B (+0.0%)
    module231 kB231 kB+106 B (+0.0%)
    react-native231 kB231 kB+106 B (+0.0%)

  • bundle

    TypeBase (bf93a38)Merge (6b2730d)Diff
    firestore (Persistence)232 kB232 kB+106 B (+0.0%)

  • firebase

    TypeBase (bf93a38)Merge (6b2730d)Diff
    firebase-compat.js755 kB755 kB+104 B (+0.0%)
    firebase-firestore-compat.js283 kB283 kB+104 B (+0.0%)
    firebase-firestore.js780 kB780 kB+391 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/IUSbBwBRuw.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 8, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • clearIndexedDbPersistence

      Size

      TypeBase (bf93a38)Merge (6b2730d)Diff
      size24.1 kB24.2 kB+106 B (+0.4%)
      size-with-ext-deps72.9 kB73.0 kB+106 B (+0.1%)

    • enableIndexedDbPersistence

      Size

      TypeBase (bf93a38)Merge (6b2730d)Diff
      size143 kB144 kB+106 B (+0.1%)
      size-with-ext-deps194 kB194 kB+106 B (+0.1%)

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (bf93a38)Merge (6b2730d)Diff
      size175 kB175 kB+106 B (+0.1%)
      size-with-ext-deps225 kB225 kB+106 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/X4svySITcX.html

@wu-hui wu-hui merged commit f5ac47f into master Feb 9, 2022
@wu-hui wu-hui deleted the mrschmidt/commit branch February 9, 2022 19:40
@google-oss-bot google-oss-bot mentioned this pull request Feb 16, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees

@wu-hui wu-hui

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @wu-hui