Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auth] Fix credentialFromResult docs #5715

Merged
merged 2 commits into from
Nov 9, 2021
Merged

[Auth] Fix credentialFromResult docs #5715

merged 2 commits into from
Nov 9, 2021

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Nov 9, 2021

No description provided.

@sam-gc sam-gc requested review from lisajian and yuchenshi November 9, 2021 19:39
@sam-gc sam-gc requested a review from avolkovi as a code owner November 9, 2021 19:39
@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 0d3d6d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/auth Patch
@firebase/auth-compat Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-cla google-cla bot added the cla: yes label Nov 9, 2021
@sam-gc sam-gc requested a review from egilmorez as a code owner November 9, 2021 19:40
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021 •
edited
Loading

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 9, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • firebase

    Type Base (3b23a9e) Head (0588dee) Diff
    firebase-auth.js 410 kB 410 kB +38 B (+0.0%)

Test Logs

@sam-gc sam-gc merged commit 1583a82 into master Nov 9, 2021
@sam-gc sam-gc deleted the sam-gc/provider-docs branch November 9, 2021 20:42
@google-oss-bot google-oss-bot mentioned this pull request Nov 10, 2021
Merged
@firebase firebase locked and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuchenshi yuchenshi yuchenshi approved these changes

@lisajian lisajian lisajian approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sam-gc @google-oss-bot @lisajian @yuchenshi