Split storage and storage-compat #5271

Feiyang1 · 2021-08-10T22:02:45Z

No description provided.

changeset-bot · 2021-08-10T22:02:48Z

⚠️ No Changeset found

Latest commit: 773f579

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR

Some errors occurred when validating the changesets config:
The package "@firebase/storage-compat" depends on the ignored package "@firebase/app-compat", but "@firebase/storage-compat" is not being ignored. Please add "@firebase/storage-compat" to the `ignore` option.
The package "@firebase/storage-compat" depends on the ignored package "@firebase/auth-compat", but "@firebase/storage-compat" is not being ignored. Please add "@firebase/storage-compat" to the `ignore` option.

common/api-review/storage.api.md

packages/storage-compat/src/reference.ts

packages/storage/src/implementation/observer.ts

packages/storage/src/implementation/taskenums.ts

google-cla · 2021-08-12T23:47:51Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

github-actions · 2021-08-14T05:47:16Z

Changeset File Check ⚠️

Changeset formatting error in following file:

Package "firebase-compat-typings-test" must depend on the current version of "firebase-exp": "9.0.0-beta.8" vs "file:../../packages-exp/firebase-exp"
ValidationError: Some errors occurred when validating the changesets config:
The package "@firebase/storage-compat" depends on the ignored package "@firebase/app-compat", but "@firebase/storage-compat" is not being ignored. Please add "@firebase/storage-compat" to the `ignore` option.
The package "@firebase/storage-compat" depends on the ignored package "@firebase/auth-compat", but "@firebase/storage-compat" is not being ignored. Please add "@firebase/storage-compat" to the `ignore` option.
    at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1096:16) {
  _error: Error
      at new ExtendableError (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/extendable-error/bld/index.js:23:24)
      at new ValidationError (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/errors/dist/errors.cjs.dev.js:16:1)
      at parse (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/config/dist/config.cjs.dev.js:206:11)
      at Object.read (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/config/dist/config.cjs.dev.js:87:10)
      at async run$1 (/home/runner/work/firebase-js-sdk/firebase-js-sdk/node_modules/@changesets/cli/dist/cli.cjs.dev.js:1096:16)
}

packages/storage-compat/test/unit/service.test.ts

Co-authored-by: Christina Holland <chholland@google.com>

google-oss-bot · 2021-08-18T19:46:37Z

Binary Size Report

Affected SDKs

`@firebase/app`

Type	Base (`0a91a90`)	Head (`a6f47dd`)	Diff
browser	11.0 kB	11.0 kB	+1 B (+0.0%)
esm2017	9.80 kB	9.80 kB	+1 B (+0.0%)
lite	8.93 kB	8.93 kB	+1 B (+0.0%)
lite-esm2017	7.93 kB	7.93 kB	+1 B (+0.0%)
main	10.1 kB	10.1 kB	+1 B (+0.0%)
module	11.0 kB	11.0 kB	+1 B (+0.0%)
react-native	9.86 kB	9.86 kB	+1 B (+0.0%)

`@firebase/firestore`

Type	Base (`0a91a90`)	Head (`a6f47dd`)	Diff
browser	285 kB	285 kB	+168 B (+0.1%)
esm2017	227 kB	227 kB	+4 B (+0.0%)
module	285 kB	285 kB	+168 B (+0.1%)
react-native	227 kB	227 kB	+4 B (+0.0%)

`@firebase/firestore-compat`

Type	Base (`0a91a90`)	Head (`a6f47dd`)	Diff
browser	29.0 kB	29.0 kB	+1 B (+0.0%)
main	38.2 kB	38.2 kB	+1 B (+0.0%)
module	29.0 kB	29.0 kB	+1 B (+0.0%)
react-native	28.7 kB	28.7 kB	+1 B (+0.0%)

`@firebase/firestore/bundle`

Type	Base (`0a91a90`)	Head (`a6f47dd`)	Diff
browser	291 kB	291 kB	+5 B (+0.0%)
esm2017	177 kB	177 kB	+5 B (+0.0%)
main	528 kB	528 kB	+1 B (+0.0%)
module	291 kB	291 kB	+5 B (+0.0%)
react-native	177 kB	177 kB	+5 B (+0.0%)

@firebase/firestore/memory

Type Base (0a91a90) Head (a6f47dd) Diff

browser 217 kB 217 kB +4 B (+0.0%)

esm2017 173 kB 173 kB +4 B (+0.0%)

module 217 kB 217 kB +4 B (+0.0%)

react-native 173 kB 173 kB +4 B (+0.0%)

`@firebase/firestore/memory-bundle`

Type	Base (`0a91a90`)	Head (`a6f47dd`)	Diff
browser	225 kB	225 kB	+5 B (+0.0%)
esm2017	177 kB	177 kB	+5 B (+0.0%)
main	322 kB	322 kB	+1 B (+0.0%)
module	225 kB	225 kB	+5 B (+0.0%)
react-native	177 kB	177 kB	+5 B (+0.0%)

@firebase/storage

Type Base (0a91a90) Head (a6f47dd) Diff

browser 64.1 kB 52.2 kB -11.9 kB (-18.6%)

main 55.8 kB 53.8 kB -1.95 kB (-3.5%)

module 64.1 kB 52.2 kB -11.9 kB (-18.6%)
@firebase/storage-compat

Type Base (0a91a90) Head (a6f47dd) Diff

browser 10.2 kB 5.67 kB -4.50 kB (-44.2%)

main 29.3 kB 8.72 kB -20.6 kB (-70.3%)

module 10.2 kB 5.67 kB -4.50 kB (-44.2%)

`firebase`

Type	Base (`0a91a90`)	Head (`a6f47dd`)	Diff
firebase-app.js	22.1 kB	22.1 kB	+3 B (+0.0%)
firebase-firestore.js	337 kB	337 kB	+4 B (+0.0%)
firebase-firestore.memory.js	271 kB	271 kB	+4 B (+0.0%)
firebase-performance-standalone.es2017.js	73.5 kB	73.5 kB	+2 B (+0.0%)
firebase-performance-standalone.js	49.9 kB	49.9 kB	+2 B (+0.0%)
firebase-storage.js	45.0 kB	17.2 kB	-27.8 kB (-61.8%)
firebase.js	896 kB	870 kB	-25.2 kB (-2.8%)

Test Logs

Base (0a91a906): https://github.com/firebase/firebase-js-sdk/actions/runs/1145700882
Head (a6f47ddc): https://github.com/firebase/firebase-js-sdk/actions/runs/1148800236

google-oss-bot · 2021-08-18T19:57:07Z

Size Analysis Report

Affected Products

No changes between base commit (4d747b1) and head commit (eb0300e).

Test Logs

packages/storage-compat/package.json

…ebase-js-sdk into fei-v9-main-storage

packages/storage-compat/package.json

google-cla · 2021-08-19T23:11:03Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

* separate storage-compat from storage * commit * fix tests * wat? * build storage-compat * save * fixing some compat tests * format * update import path * format * get compat tests to work * format * update package json * cleanup * format * address comments * Update packages/storage-compat/test/unit/service.test.ts Co-authored-by: Christina Holland <chholland@google.com> * add missing dev dep * Update packages/storage-compat/package.json * Update packages/storage-compat/package.json * Update deps after v8 release * update compat version Co-authored-by: Christina Holland <chholland@google.com> Co-authored-by: Christina Holland <hsubox@gmail.com>

* separate storage-compat from storage * commit * fix tests * wat? * build storage-compat * save * fixing some compat tests * format * update import path * format * get compat tests to work * format * update package json * cleanup * format * address comments * Update packages/storage-compat/test/unit/service.test.ts Co-authored-by: Christina Holland <chholland@google.com> * add missing dev dep * Update packages/storage-compat/package.json * Update packages/storage-compat/package.json * Update deps after v8 release * update compat version

* Split storage and storage-compat (#5271) * separate storage-compat from storage * commit * fix tests * wat? * build storage-compat * save * fixing some compat tests * format * update import path * format * get compat tests to work * format * update package json * cleanup * format * address comments * Update packages/storage-compat/test/unit/service.test.ts Co-authored-by: Christina Holland <chholland@google.com> * add missing dev dep * Update packages/storage-compat/package.json * Update packages/storage-compat/package.json * Update deps after v8 release * update compat version * Split database and database-compat (#5276) * compile database * pass database tests * compile and test database-compat * pass all tests * prettier * cleanup * fix lint * address comments * what is going on with ci * use correct case in import path * uppercase * rename * fix component name * Repo refactoring for v9 (#5325) * rename folders * rename folders * migrate app and app-compat * migrate installations and analytics * migrate app check * migrate auth * migrate functions * migrate messaging * migrate performance * migrate remoteconfig * remove v8 code * update versions * migrate firebase * fix merge issues * save * fix firebase builds * update changeset config * update build scripts * update release script * fix functions typings * remove redundant typings * update path * treat external dependencies correctly * fix lint * remove firestore-compat references * fix build issues * update build scripts * update pkg json * fix test * fix some tests * fix some tests * fix integration tests * fixes * fix dep * update ci tests * resolve todos * remove exp references * docgen build * export FirebaseError (#5349) * firebase packaging update (#5348) * Fei v9 main firestore (#5319) * compile firestore * update typings path * compile firestore compat * lint compat * make test work * get most tests work * build * remove special paths * update firestore-compat pkg json * fix merge issues * Simplify bundles * Prettier * Fix Bundle compile * Fix build * address comments * console build * Fix all tests * Prettier * fix merge issues * fix typo * update paths * app-exp * fix lint * correct path * fix * fix compat lint * fix firestore integration * fix workflow * update dep * Always block on Auth (#5340) * Always block on Auth * Don't block on token if already recevied * fix lint * build firestore * remove memory only tests * fix firebase integration tests * enable more build and tests * add firestore-compat to firebase dep * fix auth compat class * enable auth test * auth package doc * Update API reports Co-authored-by: Sebastian Schmidt <mrschmidt@google.com> Co-authored-by: Feiyang1 <Feiyang1@users.noreply.github.com> * rebasing * Create registerMessagingCompat.ts * Add changeset for v9 (#5350) * add changeset * publish messaging interop * add firestore bumps * update changeset * Revert "Create registerMessagingCompat.ts" This reverts commit 0b95a51. * Revert "rebasing" This reverts commit a8bf697. * Update index.d.ts (#5355) * Fix Context Check in `Messaging-Compat` (#5353) * Add Rules Unit Testing v2 skeleton for v9 release (#5352) * Reset package for next major version. * Switch emulator script to node-fetch. * Migrate the other request call to fetch. * Update packages/rules-unit-testing/package.json Co-authored-by: Feiyang <feiyangc@google.com> * Create stale-ducks-live.md * Revert version change. Co-authored-by: Feiyang <feiyangc@google.com> * fix import path (#5356) * Add new types and function stubs for RUT vNext. (#5316) * Add new types and function stubs. * Fix types for testEnv.emulators. * Add util functions. * Add withFunctionTriggersDisabled overloads. * Improve typing for EmulatorConfig. * Fix tests. * Rename test_environment.ts to initialize.ts. * Add a dummy test to make CI pass. * Implement emulators discovery in RUTv2. (#5334) * Add new types and function stubs. * Fix types for testEnv.emulators. * Add util functions. * Add withFunctionTriggersDisabled overloads. * Improve typing for EmulatorConfig. * Fix tests. * Rename test_environment.ts to initialize.ts. * Add a dummy test to make CI pass. * Implement emulators discovery. * Use URL object from global. * Fix unreachable error code. * Implement most of RUTv2 features. (#5343) * Implement most of RUTv2 features. * Switch to compat instances. * Remove legacy code. * Use public typings for release (#5358) * use public typings for storage * use public typings for database * Implement rest of RUTv2 features. (#5360) * Implement loading rules and withFunctionTriggersDisabled. * Implement clearFirestore and storage. * Add missing await. * Add default bucketUrl. * Use alternative method to clear bucket. * Use default param (review feedback). * Storage typing updates (#5359) * rename to StorageError * more type safety * Update API reports * update api report Co-authored-by: Feiyang1 <Feiyang1@users.noreply.github.com> * correct component name * fix installtions-compat typing * remove rules-unit-testing from ignore list * reenable things * support mjs files * correct matching pattern * transform only @firebase/util * use public types for database doc * transform all but compat packages Co-authored-by: Sebastian Schmidt <mrschmidt@google.com> Co-authored-by: Feiyang1 <Feiyang1@users.noreply.github.com> Co-authored-by: kai <zwu52@uw.edu> Co-authored-by: Yuchen Shi <yuchenshi@google.com> Co-authored-by: Kai Wu <zwu52@users.noreply.github.com>

Feiyang1 added 16 commits August 5, 2021 16:25

separate storage-compat from storage

4713a38

commit

46a8d8c

fix tests

c2fcd73

wat?

af627d2

build storage-compat

d2941ba

save

40dbf77

fixing some compat tests

6d99fb4

format

0a1d781

update import path

af3dd18

format

fe25775

get compat tests to work

63c20ae

format

c47721f

update package json

56aa473

cleanup

307ca6c

Merge branch 'master' into fei-v9-main-storage

d627474

format

3097128

Feiyang1 added the v9 label Aug 10, 2021

Feiyang1 requested review from hiranya911, hsubox76 and schmidt-sebastian as code owners August 10, 2021 22:02

hsubox76 reviewed Aug 11, 2021

View reviewed changes

Feiyang1 mentioned this pull request Aug 12, 2021

Implement mockUserToken for Storage and fix bugs. #5282

Merged

address comments

d3723ad

Feiyang1 requested review from avolkovi, egilmorez, sam-gc, yuchenshi and zwu52 as code owners August 12, 2021 23:47

Merge branch 'master' into fei-v9-main-storage

53d6a7c

Feiyang1 requested a review from jsdt as a code owner August 14, 2021 05:44

hsubox76 reviewed Aug 17, 2021

View reviewed changes

packages/storage-compat/test/unit/service.test.ts Outdated Show resolved Hide resolved

Feiyang1 and others added 3 commits August 17, 2021 23:37

Merge branch 'master' into fei-v9-main-storage

e82142d

Update packages/storage-compat/test/unit/service.test.ts

fb7e7c6

Co-authored-by: Christina Holland <chholland@google.com>

add missing dev dep

572294d

hsubox76 reviewed Aug 18, 2021

View reviewed changes

packages/storage-compat/package.json Outdated Show resolved Hide resolved

hsubox76 reviewed Aug 18, 2021

View reviewed changes

packages/storage-compat/package.json Outdated Show resolved Hide resolved

hsubox76 and others added 3 commits August 18, 2021 15:20

Update packages/storage-compat/package.json

37fba27

Merge branch 'master' into fei-v9-main-storage

a55f49c

Merge branch 'fei-v9-main-storage' of https://github.com/firebase/fir…

04d73ad

…ebase-js-sdk into fei-v9-main-storage

hsubox76 reviewed Aug 19, 2021

View reviewed changes

packages/storage-compat/package.json Outdated Show resolved Hide resolved

hsubox76 and others added 3 commits August 19, 2021 14:07

Update packages/storage-compat/package.json

5afdd50

Update deps after v8 release

6c2ddcb

Merge branch 'master' into fei-v9-main-storage

5abbf4a

Feiyang1 requested review from alikn, erikeldridge and zijianjoy as code owners August 19, 2021 23:10

update compat version

773f579

Feiyang1 merged commit d82d6f2 into fei-v9-main Aug 20, 2021

Feiyang1 deleted the fei-v9-main-storage branch August 20, 2021 00:35

firebase locked and limited conversation to collaborators Sep 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split storage and storage-compat #5271

Split storage and storage-compat #5271

Feiyang1 commented Aug 10, 2021

changeset-bot bot commented Aug 10, 2021 •

edited

Loading

google-cla bot commented Aug 12, 2021

github-actions bot commented Aug 14, 2021 •

edited

Loading

google-oss-bot commented Aug 18, 2021 •

edited

Loading

`@firebase/app`

`@firebase/firestore`

`@firebase/firestore-compat`

`@firebase/firestore/bundle`

`@firebase/firestore/memory`

`@firebase/firestore/memory-bundle`

`@firebase/storage`

`@firebase/storage-compat`

`firebase`

google-oss-bot commented Aug 18, 2021 •

edited

Loading

Affected Products

Test Logs

google-cla bot commented Aug 19, 2021

Split storage and storage-compat #5271

Split storage and storage-compat #5271

Conversation

Feiyang1 commented Aug 10, 2021

changeset-bot bot commented Aug 10, 2021 • edited Loading

⚠️ No Changeset found

google-cla bot commented Aug 12, 2021

github-actions bot commented Aug 14, 2021 • edited Loading

Changeset File Check ⚠️

google-oss-bot commented Aug 18, 2021 • edited Loading

Binary Size Report

Affected SDKs

@firebase/app

@firebase/firestore

@firebase/firestore-compat

@firebase/firestore/bundle

@firebase/firestore/memory

@firebase/firestore/memory-bundle

@firebase/storage

@firebase/storage-compat

firebase

Test Logs

google-oss-bot commented Aug 18, 2021 • edited Loading

Size Analysis Report

Affected Products

Test Logs

google-cla bot commented Aug 19, 2021

changeset-bot bot commented Aug 10, 2021 •

edited

Loading

github-actions bot commented Aug 14, 2021 •

edited

Loading

google-oss-bot commented Aug 18, 2021 •

edited

Loading

`@firebase/app`

`@firebase/firestore`

`@firebase/firestore-compat`

`@firebase/firestore/bundle`

`@firebase/firestore/memory`

`@firebase/firestore/memory-bundle`

`@firebase/storage`

`@firebase/storage-compat`

`firebase`

google-oss-bot commented Aug 18, 2021 •

edited

Loading