Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make App Check initialization explicit #4897

Merged
merged 5 commits into from
May 12, 2021
Merged

Make App Check initialization explicit #4897

merged 5 commits into from
May 12, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented May 12, 2021

Make AppCheck initialization explicit, so users not intending to use app-check won't get errors in storage, functions, etc. Modify _getService to initialize component if it hasn't been.

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2021

🦋 Changeset detected

Latest commit: af49fbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@firebase/app Patch
@firebase/app-check Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 changed the title Check app check is user-initialized before using Make App Check initialization explicit May 12, 2021
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (8bece48) and head commit (4593a88).

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

    • @firebase/app-compat

    Make sure this was intentional.

@hsubox76 hsubox76 merged commit 60e8347 into master May 12, 2021
@hsubox76 hsubox76 deleted the ch-appcheck-fix branch May 12, 2021 21:13
@google-oss-bot google-oss-bot mentioned this pull request May 12, 2021
@firebase firebase locked and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants