Refactor binary size script.

[yifanyang]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9d28ba2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[google-oss-bot]

Binary Size Report

Affected SDKs

No changes between base commit (3d0cd6f) and head commit (9ab83d9).

Test Logs

• Base (3d0cd6f3): https://github.com/firebase/firebase-js-sdk/actions/runs/532570777
• Head (9ab83d9a): https://github.com/firebase/firebase-js-sdk/actions/runs/532815309

[Feiyang1]

It looks good to me. Is there any reason for the refactoring? Does it fix any issues?

[yifanyang]

It looks good to me. Is there any reason for the refactoring? Does it fix any issues?

The issue it fixes is that previously when an exception is thrown when collecting binary size (e.g. in case of a malformed rollup output like what #4382 fixed), the script will leave the corresponding promise unhandled, and eventually let the size job fail silently on CI.