Return Firestore Classic types from Transaction API #4233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7425ef4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅
|
Size Analysis ReportAffected Products
|
| Type | Base (e13b794) | Head (540e8d6) | Diff |
|---|---|---|---|
| size_with_ext_deps | 24.9 kB | 24.2 kB | -783 B (-3.1%) |
getMessaging
Size
| Type | Base (e13b794) | Head (540e8d6) | Diff |
|---|---|---|---|
| size_with_ext_deps | 21.0 kB | 20.2 kB | -779 B (-3.7%) |
getToken
Size
| Type | Base (e13b794) | Head (540e8d6) | Diff |
|---|---|---|---|
| size_with_ext_deps | 29.5 kB | 28.7 kB | -783 B (-2.7%) |
onMessage
Size
| Type | Base (e13b794) | Head (540e8d6) | Diff |
|---|---|---|---|
| size_with_ext_deps | 22.6 kB | 21.8 kB | -779 B (-3.5%) |
Test Logs
- Base (
e13b7942): https://github.com/firebase/firebase-js-sdk/actions/runs/436438077 - Head (
540e8d66): https://github.com/firebase/firebase-js-sdk/actions/runs/440798692
thebrianchen
approved these changes
Dec 22, 2020
.changeset/slimy-mugs-type.md
Outdated
| "@firebase/firestore": patch | ||
| --- | ||
|
|
||
| Fixes an issue in the Transaction API that caused the SDK to return invalid DocumentReferences when returned from `DocumentSnapshot.data()`. |
There was a problem hiding this comment.
How about "caused DocumentSnapshot.data() to return valid DocumentReferences"? The mixing of present and past tense for "return" makes it a bit hard to understand.
There was a problem hiding this comment.
I changed it up a bit.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use the "classic" UserDataWriter in the old Transaction API, as only the classic UserDataWriter returns the old API types. This is the same fix as #4136 (and the last!)
Fixes #4226