Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Firestore Bundles as a prototype patched feature. #4168

Merged
merged 13 commits into from
Dec 8, 2020
Merged

Release Firestore Bundles as a prototype patched feature. #4168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cc8dd9c
Add bundles to d.ts and rearrange bundles source code for building it…
wu-hui Dec 3, 2020
a5b8d3a
Roll bundle with prebuilt (#4128)
wu-hui Dec 4, 2020
705b30f
Add JSDoc for bundles (#4155)
wu-hui Dec 4, 2020
5910464
Merge branch 'master' into wuandy/ReleaseBundles
wu-hui Dec 4, 2020
b4050e6
Create changeset
wu-hui Dec 4, 2020
f8bb4d8
Update old-lobsters-pull.md
wu-hui Dec 4, 2020
aae9956
Merge branch 'master' into wuandy/ReleaseBundles
wu-hui Dec 5, 2020
931621e
A few fixes for Firestore bundle sdk builds (#4177)
wu-hui Dec 7, 2020
cad128f
Address comments
wu-hui Dec 7, 2020
bf49a5b
Update .changeset/old-lobsters-pull.md
wu-hui Dec 7, 2020
d8543e3
Update .changeset/old-lobsters-pull.md
wu-hui Dec 7, 2020
0f8e555
Add toc.
wu-hui Dec 7, 2020
e830a23
Remove webpack change.
wu-hui Dec 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .changeset/old-lobsters-pull.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@
"@firebase/firestore": minor
---

Release Firestore Bundles as a prototype patched feature.
Release Firestore Bundles (pre-packaged Firestore data). For ESM usage, this can
wu-hui marked this conversation as resolved.
Show resolved Hide resolved
be enabled via additional import: 'firebase/firestore/bundle'. For CDN usage,
wu-hui marked this conversation as resolved.
Show resolved Hide resolved
it is enabled by default.
4 changes: 2 additions & 2 deletions packages/firestore/src/core/sync_engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1537,8 +1537,8 @@ export function ensureWriteCallbacks(syncEngine: SyncEngine): SyncEngineImpl {
* Loads a Firestore bundle into the SDK. The returned promise resolves when
* the bundle finished loading.
*
* @param bundleReader Bundle to load into the SDK.
* @param task LoadBundleTask used to update the loading progress to public API.
* @param bundleReader - Bundle to load into the SDK.
* @param task - LoadBundleTask used to update the loading progress to public API.
*/
export function syncEngineLoadBundle(
syncEngine: SyncEngine,
Expand Down
1 change: 0 additions & 1 deletion packages/firestore/src/local/local_store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1395,7 +1395,6 @@ export function hasNewerBundle(

/**
* Saves the given `BundleMetadata` to local persistence.
* @param bundleMetadata
*/
export function saveBundle(
localStore: LocalStore,
Expand Down