Fix out-of-order execution for enqueueRetryable #3919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 00f6cd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wilhuff
approved these changes
Oct 10, 2020
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@firebase/firestore": patch | |||
There was a problem hiding this comment.
Do we also need a patch for the firebase-wide package?
There was a problem hiding this comment.
I believe that we don't need to for a patch release, since every release is at least a minimum patch version bump.
Binary Size ReportAffected SDKs
Test Logs
|
Size Analysis ReportAffected ProductsNo changes between base commit (88e1f88) and head commit (c2dff5e). Test Logs
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently do follow the global order of AsyncQueue operations when we insert items into the retryable queue. This seems to allow operations that inserted into the retryable queue to skip ahead of items that are inserted into the regular queue. This PR ties the insertion of new items to the retryable queue to the order in which all items are enqueue.
I still am not able to reproduce the original failure in a unit test (tried various delays, various order of operations, scheduling operations while other operations are running), but this code change addresses the consistent Integration tests failures in a follow-up PR.