Change Error to FirestoreError #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 7594809 We got this. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…nd firestore-types/index.d.ts.
Binary Size ReportAffected SDKsNo changes between base commit (f47f990) and head commit (5abf4fc). Test Logs
|
schmidt-sebastian
approved these changes
Jul 17, 2020
Size Analysis ReportAffected ProductsNo changes between base commit (f47f990) and head commit (5abf4fc). Test Logs
|
Changeset File Check
|
|
I'm going to merge despite the "Test All Packages" check failing. Its failure is due to a timeout and is not critical to this feature. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the signature of
onSnapshot()andonSnapshotsInSync()methods to reportFirestoreErrorinstead of a genericError. This allows users to extract the error code from the error without having to do a questionable cast.This will address #1515 for Firestore. A separate PR will be needed for Storage.