Fix nodejs builds (#5400)

* remove named export from app-compat

* cjs build

* firestoer lite export

* changeset

.changeset/eleven-swans-drive.md

@@ -0,0 +1,8 @@
+---
+'@firebase/analytics-compat': patch
+'@firebase/app-check-compat': patch
+'@firebase/app-compat': patch
+'@firebase/functions-compat': patch
+---
+
+Fix cjs builds by removing the named export from app-compat

.changeset/late-bobcats-swim.md

@@ -0,0 +1,5 @@
+---
+'@firebase/firestore': patch
+---
+
+Make firestore/lite available in nodejs

packages/analytics-compat/src/service.test.ts

@@ -16,7 +16,7 @@
  */
 import { expect, use } from 'chai';
 import { AnalyticsService } from './service';
-import { firebase, FirebaseApp } from '@firebase/app-compat';
+import firebase, { FirebaseApp } from '@firebase/app-compat';
 import * as analyticsExp from '@firebase/analytics';
 import { stub, match, SinonStub } from 'sinon';
 import * as sinonChai from 'sinon-chai';

packages/app-check-compat/src/service.test.ts

@@ -16,7 +16,7 @@
  */
 import { expect, use } from 'chai';
 import { AppCheckService } from './service';
-import { firebase, FirebaseApp } from '@firebase/app-compat';
+import firebase, { FirebaseApp } from '@firebase/app-compat';
 import * as appCheckExp from '@firebase/app-check';
 import { stub, match, SinonStub } from 'sinon';
 import * as sinonChai from 'sinon-chai';
@@ -65,7 +65,7 @@ describe('Firebase App Check > Service', () => {
 
   it(
     'activate("string") calls modular initializeAppCheck() with a ' +
-      'ReCaptchaV3Provider',
+    'ReCaptchaV3Provider',
     () => {
       const initializeAppCheckStub = stub(appCheckExp, 'initializeAppCheck');
       service = new AppCheckService(app);
@@ -80,7 +80,7 @@ describe('Firebase App Check > Service', () => {
 
   it(
     'activate(CustomProvider) calls modular initializeAppCheck() with' +
-      ' a CustomProvider',
+    ' a CustomProvider',
     () => {
       const initializeAppCheckStub = stub(appCheckExp, 'initializeAppCheck');
       service = new AppCheckService(app);
@@ -167,7 +167,7 @@ describe('Firebase App Check > Service', () => {
 
   it('onTokenChanged() throws if activate() has not been called', async () => {
     service = createTestService(app);
-    expect(() => service.onTokenChanged(() => {})).to.throw(
+    expect(() => service.onTokenChanged(() => { })).to.throw(
       AppCheckError.USE_BEFORE_ACTIVATION
     );
   });

packages/app-compat/src/index.lite.ts

@@ -18,7 +18,7 @@
 import { createFirebaseNamespaceLite } from './lite/firebaseNamespaceLite';
 import { registerCoreComponents } from './registerCoreComponents';
 
-export const firebase = createFirebaseNamespaceLite();
+const firebase = createFirebaseNamespaceLite();
 
 registerCoreComponents('lite');
 

packages/app-compat/src/index.ts

@@ -39,7 +39,7 @@ if (isBrowser() && (self as any).firebase !== undefined) {
   }
 }
 
-export const firebase = firebaseNamespace;
+const firebase = firebaseNamespace;
 
 registerCoreComponents();
 

packages/firestore/package.json

@@ -45,6 +45,16 @@
     "test:prepare": "node ./scripts/prepare-test.js",
     "typings:public": "node ../../scripts/exp/use_typings.js ./dist/index.d.ts"
   },
+  "exports": {
+    ".": {
+      "node": "./dist/index.node.cjs.js",
+      "default": "./dist/index.esm2017.js"
+    },
+    "./lite": {
+      "node": "./dist/lite/index.node.cjs.js",
+      "default": "./dist/lite/index.browser.esm2017.js"
+    }
+  },
   "main": "dist/index.node.cjs.js",
   "main-esm": "dist/index.node.cjs.esm2017.js",
   "react-native": "dist/index.rn.js",

packages/functions-compat/src/callable.test.ts

@@ -17,7 +17,7 @@
 import { expect } from 'chai';
 import { FunctionsErrorCode } from '@firebase/functions';
 import { createTestService } from '../test/utils';
-import { firebase, FirebaseApp } from '@firebase/app-compat';
+import firebase, { FirebaseApp } from '@firebase/app-compat';
 
 // eslint-disable-next-line @typescript-eslint/no-require-imports
 export const TEST_PROJECT = require('../../../config/project.json');

packages/functions-compat/src/index.node.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import { firebase } from '@firebase/app-compat';
+import firebase from '@firebase/app-compat';
 import { name, version } from '../package.json';
 import { registerFunctions } from './register';
 

packages/functions-compat/src/service.test.ts

@@ -17,7 +17,7 @@
 import { expect, use } from 'chai';
 import { createTestService } from '../test/utils';
 import { FunctionsService } from './service';
-import { firebase, FirebaseApp } from '@firebase/app-compat';
+import firebase, { FirebaseApp } from '@firebase/app-compat';
 import * as functionsExp from '@firebase/functions';
 import { stub, match, SinonStub } from 'sinon';
 import * as sinonChai from 'sinon-chai';