Update streaming callable API #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
Dec 13, 2024
inlined
force-pushed
the
inlined.streaming-changes
branch
from
004787c to
702719d
Compare
Berlioz
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Update streaming callable API * Fix linter error * Stream type defaults to unknown * Changelog * Format fix
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
…n top-level awaits (#1651) * Use await import instead of require for functions modules that contain top-level awaits * tests ensuring that es modules with top level awaits can be loaded * adds node 22 to the CI matrix on github * Add support for an authPolicy that returns Permission Denied when failed (#1650) * Add support for an authPolicy that returns Permission Denied when failed * Formatter * Changelog * remove ignorant comment * Update streaming callable API (#1652) * Update streaming callable API * Fix linter error * Stream type defaults to unknown * Changelog * Format fix * update changelog.md --------- Co-authored-by: Thomas Bouldin <inlined@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the (not yet documented) streaming API for v2 Callable functions.
CallableProxyResponseis nowCallableResponse(to matchCallableRequest)acceptsStreaminghas been moved toCallableRequestbecause it is a request propertyCallableResponse.writehas been renamedCallableResponse.sendChunkpartially to match Genkit and partially to avoid confusion where "write" acts very differently (accepts raw data, has a callback)CallableResponse.sendChunkreturns a Promise so that errors are no longer swallowedstreammethod though its implementation will come at a later date